Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add huawei cloud registry support #67

Merged
merged 20 commits into from
Jul 13, 2021
Merged

add huawei cloud registry support #67

merged 20 commits into from
Jul 13, 2021

Conversation

dyliu
Copy link
Contributor

@dyliu dyliu commented Jul 9, 2021 •
edited by landylee007
Loading

Signed-off-by: liu deyi andrew@koderover.com

What this PR does / Why we need it:

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Check List

  • Docs have been added / updated
  • Unit test / Integration test for the changes have been added
  • Manual test (add detailed scripts or steps below)
  • No code

More information

This change is Reviewable

@dyliu
add huawei cloud registry support
7875b09 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu dyliu changed the title add huawei cloud registry support wip:add huawei cloud registry support Jul 9, 2021
dyliu added 10 commits July 9, 2021 16:10
@dyliu
add region
1ad2dc0 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
modify registry's ak/sk
079290b 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
get service by provide
203f96a 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
debug registry secret
9f1f2ae 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
replace 回车
b648527 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
modify /bin/bash to /bin/sh
3573fd5 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
debug task
8d632e2 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
optimize code
0fbdf44 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
optimize code
18c444d 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
dockerfile add install openssl script
a80b090 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu dyliu requested a review from 27149chen July 12, 2021 06:52
@dyliu dyliu changed the title wip:add huawei cloud registry support add huawei cloud registry support Jul 12, 2021
dyliu added 5 commits July 12, 2021 21:04
@dyliu
get image size
fc62d38 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
debug get image size
46de2e6 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
remove debug
fbb81d9 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
remove registry pointer
c8cb598 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
modify annotation
56812bd 
Signed-off-by: liu deyi <andrew@koderover.com>
27149chen
27149chen suggested changes Jul 13, 2021
View reviewed changes
pkg/microservice/aslan/core/common/service/registry/service.go Show resolved Hide resolved
pkg/microservice/aslan/core/common/service/registry/service.go Outdated Show resolved Hide resolved
pkg/microservice/aslan/core/common/service/registry.go Outdated Show resolved Hide resolved
pkg/microservice/aslan/core/common/service/registry/service.go Show resolved Hide resolved
pkg/microservice/aslan/core/common/service/registry/service.go Outdated Show resolved Hide resolved
pkg/microservice/aslan/core/common/service/registry/service_test.go Show resolved Hide resolved
pkg/microservice/aslan/core/common/service/registry/types.go Outdated Show resolved Hide resolved
pkg/microservice/aslan/core/workflow/service/workflow/workflow_task.go Outdated Show resolved Hide resolved
pkg/util/exec/exec.go Outdated Show resolved Hide resolved
dyliu added 4 commits July 13, 2021 17:34
@dyliu
modify code
2c5c61b 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
modify code after code review
c31ed2b 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
modify the import order of dependent packages
700744a 
Signed-off-by: liu deyi <andrew@koderover.com>
@dyliu
modify swrclient's alias
257b559 
Signed-off-by: liu deyi <andrew@koderover.com>
@27149chen 27149chen merged commit 875b353 into koderover:main Jul 13, 2021
@dyliu dyliu deleted the support_Huawei_registry branch October 29, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@27149chen 27149chen 27149chen requested changes

Assignees
No one assigned
Labels
service/aslan service/warpdrive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyliu @27149chen