Skip to content

cp: cherry pick #4989 to release 5.0.0 - #4999

Open
huanghongbo-hhb wants to merge 1 commit into
koderover:release-5.0.0from
huanghongbo-hhb:cp/release-5.0.0#4989
Open

huanghongbo-hhb wants to merge 1 commit into
koderover:release-5.0.0from
huanghongbo-hhb:cp/release-5.0.0#4989

Conversation

@huanghongbo-hhb

@huanghongbo-hhb huanghongbo-hhb commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Changes

  • Propagate DisableSSL when adding and removing workflow webhooks.
  • Isolate each GitLab client HTTP transport instead of mutating http.DefaultClient.

Risk / Compatibility

  • Preserves existing verification defaults and prevents cross-client TLS state pollution.

Test

  • go test ./pkg/tool/git/gitlab -run TestNewClientDoesNotModifyDefaultHTTPClient -count=1
  • go test -vet=off ./pkg/tool/git/gitlab -count=1
  • go test -vet=off ./pkg/microservice/aslan/core/common/service -count=1

Contact

Contact: huanghongbo@koderover.com


This change is Reviewable

Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
(cherry picked from commit d6fe666)
@huanghongbo-hhb huanghongbo-hhb changed the title fix: honor disabled SSL verification for GitLab webhooks cp: cherry pick #4989 to release 5.0.0 Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants