Swift style guide Chinese edition #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrahmiao <mrahmiao@gmail.com>
Signed-off-by: mrahmiao <mrahmiao@gmail.com>
Signed-off-by: mrahmiao <mrahmiao@gmail.com>
Signed-off-by: mrahmiao <mrahmiao@gmail.com>
Signed-off-by: mrahmiao <mrahmiao@gmail.com>
Signed-off-by: mrahmiao <mrahmiao@gmail.com>
Signed-off-by: mrahmiao <mrahmiao@gmail.com>
|
Awesome! I took the liberty to read over this and its quite polished.
More eyes on this would be helpful. |
|
You mean the last few lines of code? |
…the code part in naming section Signed-off-by: mrahmiao <mrahmiao@gmail.com>
Signed-off-by: mrahmiao <mrahmiao@gmail.com>
|
Yes that is exactly what I meant, looks great! |
rwenderlich
added a commit
that referenced
this pull request
Jul 7, 2014
Swift style guide Chinese edition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please modify it if anything is not appropriate.