Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt Speed kit test #7805

Closed
wants to merge 9 commits into from
Closed

Nuxt Speed kit test #7805

wants to merge 9 commits into from

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Oct 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Copilot Summary

🤖 Generated by Copilot at 454f382

Added nuxt-speedkit module to optimize website performance. This is part of a pull request that improves the loading speed and user experience of the NFT gallery website.

🤖 Generated by Copilot at 454f382

nuxt-speedkit added
to boost Nuxt gallery site
winter wind is swift

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for koda-canary failed.

Name Link
🔨 Latest commit c442c8b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6537d6a51cfb50000774224c

@reviewpad reviewpad bot added the large Pull request is large label Oct 24, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 24, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 24, 2023

AI-Generated Summary: This pull request reveals that a new dependency, 'nuxt-speedkit' version 2.2.3, has been added to the package.json file. No other modifications are present.

@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

Lighthouse reports

On mobile, it doesn't seem to have an impact, yet on desktop, it does improves 10 points on average.

Current canary
image
vs this PR
image

We can tune settings later.

@yangwao yangwao marked this pull request as ready for review October 24, 2023 13:55
@yangwao yangwao requested a review from a team as a code owner October 24, 2023 13:55
@yangwao yangwao requested review from roiLeo and daiagi and removed request for a team October 24, 2023 13:55
@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

Has impact on other metrics

Canary

image
This PR

image

@prury
Copy link
Member

prury commented Oct 24, 2023

deploy failed

@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

deploy failed

reseted cache on netlify, strange, it's happence once a while but not often, I sense something will explode soon lol

@prury
Copy link
Member

prury commented Oct 24, 2023

deploy failed

reseted cache on netlify, strange, it's happence once a while but not often, I sense something will explode soon lol

minimalist koda version:

image

@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

minimalist koda version:

this one has worked https://6537c9f104be790008ad5a84--koda-canary.netlify.app/ that means zero config is it for now, let's see

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what-are-you-doing

package looks a bit outdated (last update was +6month ago)

@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

bumping to next v3 version, works on permalink deploy
544f874 -> https://6537c9f104be790008ad5a84--koda-canary.netlify.app/

removing config, doesn't work any more, what
dbefdf7 -> https://6537d0eb28193c00080448b0--koda-canary.netlify.app/

package looks a bit outdated (last update was +6month ago)

I see 2 weeks ago?

pnpm info nuxt-speedkit@next

nuxt-speedkit@3.0.0-next.27 | MIT | deps: 14 | versions: 205
Nuxt Speedkit takes over the Lighthouse performance optimization of your generated website.
https://github.com/GrabarzUndPartner/nuxt-speedkit#readme

...
...
dist-tags:
beta: 2.2.1-beta.1   latest: 2.2.3        next: 3.0.0-next.27

published 2 weeks ago by gp-dev <dev@grabarzundpartner.de>

basics/nuxt-booster#542

@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

I sense something is wrong with Netlify or Nuxt3.8 it's failing builds randomly, same error different lines mm, well at least worked initially.

@codeclimate
Copy link

codeclimate bot commented Oct 24, 2023

Code Climate has analyzed commit c442c8b and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
browserslist 4.22.1 None +1 76.1 kB ai
browserslist-useragent-regexp 4.1.0 None +2 278 kB dangreen

@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

image
vs this PR
image

This seems completely random, then, as nuxt-speedkit was never loaded by config.

Continue to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants