Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null collection in /drops pages #6994

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 28, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 255ad14

Updated the collection ID format and fixed a bug in the useDrops function. These changes enable user collections and improve the stability of the drops feature.

🤖 Generated by Copilot at 255ad14

STT_COLLECTION_ID
New format with prefix u-
User collections bloom

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 28, 2023 03:55
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team August 28, 2023 03:55
@kodabot
Copy link
Collaborator

kodabot commented Aug 28, 2023

SUCCESS @Jarsen136 PR for issue #6992 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0aebd2e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ec1ed23f0fff0008b6e2d9
😎 Deploy Preview https://deploy-preview-6994--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 28, 2023

AI-Generated Summary: This pull request addresses a null collection issue in the /drops pages. Changes were made in two files: 'components/collection/drop/const.ts' and 'components/drops/useDrops.ts'. In the first file, the constant 'STT_COLLECTION_ID' was updated. In the second file, a check for 'collectionEntity' was added within 'collectionData.value'. This helps ensure the presence of 'collectionEntity' before proceeding further in the logic.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 28, 2023
@daiagi
Copy link
Contributor

daiagi commented Aug 28, 2023

That was fast

giphy

@daiagi
Copy link
Contributor

daiagi commented Aug 28, 2023

wfm
would you mind deleting the console.log from the page?

@codeclimate
Copy link

codeclimate bot commented Aug 28, 2023

Code Climate has analyzed commit 0aebd2e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@Jarsen136
Copy link
Contributor Author

wfm would you mind deleting the console.log from the page?

Sure. I deleted it.

@yangwao
Copy link
Member

yangwao commented Aug 28, 2023

pay 20 usd

@yangwao yangwao merged commit a6a56f1 into kodadot:main Aug 28, 2023
@yangwao
Copy link
Member

yangwao commented Aug 28, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.45 USD/DOT ~ 4.494 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x4e822cd31b484ff4694977e6496b82647fe24c7c622ab9ff8a7e8b2afee5e247

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 28, 2023
@Jarsen136 Jarsen136 mentioned this pull request Aug 29, 2023
1 task
This was referenced Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null collection in /drops pages
5 participants