-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: filter out polkadot from chain selector #6748
Conversation
WARNING @preschian PR for issue #6494 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6494 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes three separate patches. The first patch modifies the The second patch refactors the The third patch carries out a refactor of the |
Code Climate has analyzed commit 1684c48 and detected 0 issues on this pull request. View more on Code Climate. |
Isn't is simplier to make which would state if its visible for user therefore function isVisible(prefix: Prefix): boolean {
return visible[prefix] ?? true
} type PartialConfig<T> = Record<Partial<Prefix>, T>
const visible: PartialConfig<boolean> = {
dot: false
} |
cc @preschian check the comment above |
In which line do we put this? and how we differentiate based on env. currently, we have two visible categories
|
@JustLuuuu will be now happy |
Let's proceed with this quickie |
Kudos, SonarCloud Quality Gate passed!
|
Hello guys! Just noticed that explorerVisible got removed here but there are still some files referencing it. Thank you so much @vikiival @yangwao @preschian |
hi @stephenjason89, let's revert it back on permission.config |
@preschian noted on this. Will do a PR now |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Did your issue had any of the "$" label on it?