Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(addressParser): to script setup composition api #6687

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

stephenjason89
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 12, 2023 08:59
@stephenjason89 stephenjason89 requested review from roiLeo and Jarsen136 and removed request for a team August 12, 2023 08:59
@netlify
Copy link

netlify bot commented Aug 12, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3d60712
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d767836adfd70007ae5f04
😎 Deploy Preview https://deploy-preview-6687--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 12, 2023

AI-Generated Summary: This pull request refactors the AddressParser.vue component in the accounts module. The code now uses the script setup composition API of Vue 3. The @Component decorator, along with its property decorators, @Prop and @Emit, has been removed. Instead, the defineEmits and defineProps functions have been used to define component's props and emitted events. Furthermore, the handleInput function, which was previously a class method, has been transformed into a standalone function. This change results in a more concise and modern Vue.js component.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 12, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 12, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Aug 12, 2023

Code Climate has analyzed commit 3d60712 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao
Copy link
Member

yangwao commented Aug 12, 2023

this is highly sensitive stuff, recommend test this one well
cc @prury

@prury
Copy link
Member

prury commented Aug 13, 2023

was able to input addresses properly ✔️
number of total addresses was correct ✔️
simple mint transferred the NFTs to addresses correctly ✔️
https://kusama.subscan.io/tx/0xaae93b4c05c6b9883e3804f08eb93402e60d202b90cb4c6137a1170400301eb8
https://kusama.subscan.io/tx/0xfd1a8ec25f3622e7cf852bd897cc93906766ad3f977cb6516f3258224c32fd70

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 13, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm, keep it up

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Aug 13, 2023
@yangwao
Copy link
Member

yangwao commented Aug 13, 2023

pay 50 usd

@yangwao yangwao merged commit 5809047 into kodadot:main Aug 13, 2023
@yangwao
Copy link
Member

yangwao commented Aug 13, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.03 USD/DOT ~ 9.94 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0xf78c81721f516c292968082cc783aa5f7edbecf3ef6d6983e337222657bce808

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 13, 2023
This was referenced Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants