🔧 bsx/snek offers composition api #6633
Conversation
roiLeo
requested review from
preschian and
vikiival
and removed request for
a team
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
AI-Generated Summary: This pull request involves a modification in 'Offer' functionality of an application and makes substantial changes in the 'MyOffer.vue' and 'OffersUserTable.vue' files. It primarily focuses on migrating from employing mixins for shared functionality towards using the composable approach in Vue.js codebase. In 'MyOffer.vue', it replaces the older mixins with Vue Composition API logic, using functions including 'useMetaTransaction', 'useNuxtApp', 'usePrefix', and 'useAuth'. It also appears to modify the 'fetchMyOffers' function to make use of the Apollo client for querying data. Regarding 'OffersUserTable.vue', this patch manages to replace the mixins with 'useMetaTransaction', 'usePrefix', 'useAuth' and 'useNuxtApp'. It also restructures the 'withdrawOffer' function to use Vue Composition API. Additionally, it deletes the redundant 'offerMixin.ts' file that earlier defined shared mixin functionality across components. These changes offer improved code readability and maintainability by using the composable pattern rather than mixins. |
|
Reviewpad Report
|
|
luckily i have some offers for testing purposes:
|
components/bsx/Offer/MyOffer.vue
Outdated
| if (targetAddress.value) { | ||
| // $apollo.addSmartQuery<OfferResponse>('offers', { | ||
| // client: client.value, | ||
| // query: acceptableOfferByCurrentOwner, | ||
| // variables: { id: targetAddress.value }, | ||
| // manual: true, | ||
| // result: ({ data }) => setResponse(data), | ||
| // pollInterval: 10000, | ||
| // }) |
There was a problem hiding this comment.
I don't.
Didn't we made something like this to refresh data on GalleryItem?
There was a problem hiding this comment.
GalleryItem should be a separate data island
There was a problem hiding this comment.
Introducing manual refresh button
Should be fixed now (I guess??)
|
yeee
|
prury
added
the
S-works-for-me-✅
|
Code Climate has analyzed commit 470fa10 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
note: I didn't test all features (looks like doesn't work on beta)