Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clicking on Activity while searching different collections shows… #6425

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jul 11, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 4405c5c

Refactored TabOnCollection.vue to use composition API and computed properties for better reactivity and navigation.

🤖 Generated by Copilot at 4405c5c

toItem, toActivity
now computed properties
react to route changes

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 11, 2023 14:44
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team July 11, 2023 14:44
@kodabot
Copy link
Collaborator

kodabot commented Jul 11, 2023

SUCCESS @Jarsen136 PR for issue #6424 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4405c5c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ad6abe3f4e8b0008870b3e
😎 Deploy Preview https://deploy-preview-6425--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 11, 2023

AI-Generated Summary: This pull request addresses a bug in the 'TabOnCollection.vue' component. The issue arises when the user clicks on 'Activity' while searching different collections, showing previous collections instead of the current one. The changes in this patch refactor the 'toItem' and 'toActivity' paths from being simple constants to computed properties, so that they reflect the current 'route' state. These changes ensure that the paths to the current collection and its activity are dynamically updated depending on the active route parameters.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 11, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 11, 2023

Code Climate has analyzed commit 4405c5c and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 5befc8d into kodadot:main Jul 11, 2023
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 11, 2023
This was referenced Jul 17, 2023
This was referenced Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on Activity while searching different collections shows previous collection
5 participants