Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 migrate b-slider to NeoSlider #6340

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 27, 2023

part of #5852, tested on /rmrk/mint

  • b-slider => NeoSlider
  • vue composition api BasicSlider
  • fixed AttributeTagInput error

Screenshot 2023-06-27 at 14-00-25 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner June 27, 2023 12:37
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team June 27, 2023 12:37
@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 58d00fd
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/649c2b646004460008107422
😎 Deploy Preview https://deploy-preview-6340--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 27, 2023

AI-Generated Summary: This pull request migrates the b-slider component to the oruga library. It introduces a new NeoSlider component, updates the BasicSlider component, and modifies the Create/SimpleMint.vue file to use the new NeoSlider. 4 files have been changed, with 49 insertions and 23 deletions. A new file, NeoSlider.vue, has been created under the components folder in the library.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 27, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 27, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo mentioned this pull request Jun 27, 2023
37 tasks
components/rmrk/Create/SimpleMint.vue Outdated Show resolved Hide resolved
@prury
Copy link
Member

prury commented Jun 27, 2023

took me some time to find the right conditions for the slider to appear 💀
lmk if the distribution itself needs to be tested via minting

edit: #6343

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 27, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 28, 2023

Code Climate has analyzed commit 58d00fd and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 28, 2023

took me some time to find the right conditions for the slider to appear 💀 lmk if the distribution itself needs to be tested via minting

I don't even know what "distribution" does

@prury
Copy link
Member

prury commented Jun 28, 2023

took me some time to find the right conditions for the slider to appear 💀 lmk if the distribution itself needs to be tested via minting

I don't even know what "distribution" does

haha i think its to supposed to send a specific amount(defined by the slider) of the NFTs you minted to the address list above, but i'm not sure either

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jun 28, 2023
@yangwao yangwao merged commit a9228df into kodadot:main Jun 29, 2023
@yangwao yangwao mentioned this pull request Jun 29, 2023
@roiLeo roiLeo deleted the chore/Buefy/b-slider branch June 29, 2023 12:24
This was referenced Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants