-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Success notification unlockable drop #6213
Conversation
SUCCESS @Jarsen136 PR for issue #6204 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request introduces a new feature for displaying a success notification when an unlockable drop is minted. It adds a new component called UnlockableLoader.vue and makes minor modifications to the UnlockableContainer.vue component. The success notification is shown for 30 seconds after minting and includes a "View Item" button. |
Great work! Is there a way to activate the popup without minting the NFT? Could you guide me to a resource where I can find more information on this? Thanks! |
Yes, I have made a preview env for testing. Opening the page with parms I will remove this testing logic before the PR is about to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roiLeo its a different success, the one for drop page is in figma drop page edit: Yeah, I will make some changes |
merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in anticipation of a unified design, let's roll
Okay, sorry for changing it now. Let's make the text 16px Ad @roiLeo We plan to implement a unified design that includes redesigned notification toasts. It seems that this style will be used for most of our notifications. |
okay, a few minor changes
Thanks! Maybe + change the copy a bit and add that it will be visible in the 30s on your profile, for people that closed the dialog :D |
Code Climate has analyzed commit cdff8b3 and detected 0 issues on this pull request. View more on Code Climate. |
It's already there.
✅ Updated |
Cool, I think I will create one more issue for some small things, I don't want to hold up this one. Thanks! visual oki 🏁 |
pay 30 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs Design check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 2f58564
Added a new
UnlockableLoader
component to improve the user experience when minting and viewing unlockable NFTs. Replaced the oldLoader
component with the new one in theUnlockableContainer
component. Used some components and hooks from the@kodadot1/brick
library.🤖 Generated by Copilot at 2f58564