Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 NeoIcon defaultIcon pack sharp #6170

Merged
merged 3 commits into from
Jun 13, 2023
Merged

🔧 NeoIcon defaultIcon pack sharp #6170

merged 3 commits into from
Jun 13, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 6, 2023 •
edited
Loading

fa-sharp isn't an icon pack, replaced by fas

@roiLeo roiLeo requested a review from a team as a code owner June 6, 2023 06:43
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team June 6, 2023 06:43
@netlify
Copy link

netlify bot commented Jun 6, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2ccf849
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6488209e3313ba0008e11d09
😎 Deploy Preview https://deploy-preview-6170--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

AI-Generated Summary: This pull request updates the NeoIcon component in NeoIcon.vue by making the following changes:

  1. Removing the iconPack computed property.
  2. Replacing the use of iconPack with a more straightforward expression, pack || 'fas', for setting the default pack as 'fas' in the o-icon component.

Additionally, this patch removes 3 lines of code while only inserting 1 new line, leading to a simpler and cleaner implementation.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 6, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo requested a review from preschian June 13, 2023 07:36
preschian
preschian approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor by deepscan, otherwise lgtm 👍

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 13, 2023

minor by deepscan, otherwise lgtm 👍

908

@codeclimate
Copy link

codeclimate bot commented Jun 13, 2023

Code Climate has analyzed commit 2ccf849 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit c5daab2 into kodadot:main Jun 13, 2023
@vikiival
Copy link
Member

image

Really happy to see this button green instead of red

@roiLeo roiLeo deleted the hotfix/NeoIcon/defaultIconPack branch June 13, 2023 09:45
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 13, 2023

Hello! We have a small visual change here, sorry for any inconvenience

Screenshot 2023-06-13 at 16-33-36 KodaDot - NFT Market Explorer

This was referenced Jun 13, 2023
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival vikiival approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roiLeo @vikiival @preschian