Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minting visual bugs #5798

Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: Minting visual bugs #5798

merged 1 commit into from
Apr 24, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Apr 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

Copilot Summary

🤖 Generated by Copilot at 9420046

Updated the .field class in styles/global.scss to change the border color of form elements. This improves the visual consistency and accessibility of the gallery UI.

🤖 Generated by Copilot at 9420046

field class gets styled
border color is lighter
a hint of winter

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 24, 2023 16:28
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team April 24, 2023 16:28
@kodabot
Copy link
Collaborator

kodabot commented Apr 24, 2023

SUCCESS @Jarsen136 PR for issue #5797 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9420046
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6446ae1b3cceff00086957f3
😎 Deploy Preview https://deploy-preview-5798--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 24, 2023

AI-Generated Summary: This pull request includes a patch that fixes minting visual bugs by making changes in the global.scss file. It introduces 8 new lines of code to address the issues with border colors and input field styles. Specifically, it adjusts the border-color of .input, select, and textarea elements within the .field class, and also modifies the height property of .taginput-container.is-focusable.

@codeclimate
Copy link

codeclimate bot commented Apr 24, 2023

Code Climate has analyzed commit 9420046 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 24, 2023
@vikiival vikiival merged commit 14efd23 into kodadot:main Apr 24, 2023
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minting visual bugs
3 participants