Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loading preview for NFTs in search doesnt work #5742

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Apr 20, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

Copilot Summary

🤖 Generated by Copilot at 6ee4e97

Refactor and improve image handling in SearchSuggestion component. Use sanitizeIpfsUrl function to support different media types and fallbacks, and simplify component props and data.

🤖 Generated by Copilot at 6ee4e97

To display images from IPFS
The code needed some fixes
It used sanitizeIpfsUrl
To handle media well
And simplified the component's prefixes

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 20, 2023 15:25
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team April 20, 2023 15:25
@kodabot
Copy link
Collaborator

kodabot commented Apr 20, 2023

SUCCESS @Jarsen136 PR for issue #5740 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6ee4e97
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64415989f0c6dc0008a27254
😎 Deploy Preview https://deploy-preview-5742--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 20, 2023

AI-Generated Summary: This pull request addresses the issue of loading previews for NFTs in search not working. It makes changes to the SearchSuggestion.vue file, updating the image handling and URL sanitization methods. Specifically, it replaces the getSanitizer function with sanitizeIpfsUrl, and modifies the handling of images, animation URLs, and media URIs.

@codeclimate
Copy link

codeclimate bot commented Apr 20, 2023

Code Climate has analyzed commit 6ee4e97 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 20, 2023
@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

perfect it works!

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 32.86 USD/KSM ~ 0.913 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xc444301cc111fecf903277f9d248a649c8199597b4e82b4a5fa4f25beb332868

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 20, 2023
@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

oh if we can get square for NFTs like in

I've forgot about to add that to issue :|

@yangwao yangwao merged commit b11c88c into kodadot:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading preview for NFTs in search doesn't work
4 participants