Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/massmint upload media zip #5701

Merged
merged 17 commits into from
Apr 20, 2023
Merged

Feature/massmint upload media zip #5701

merged 17 commits into from
Apr 20, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Apr 17, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screencast.from.17-04-23.21.04.07.webm

🤖 Generated by Copilot at 7e3a207

Sing, O Muse, of the skillful coder who devised
A wondrous feature for the NFT gallery, where many
Artists and collectors gather to admire and trade
The digital tokens of their creative works and passions.

@daiagi daiagi requested a review from a team as a code owner April 17, 2023 13:40
@daiagi daiagi requested review from preschian and vikiival and removed request for a team April 17, 2023 13:40
@kodabot
Copy link
Collaborator

kodabot commented Apr 17, 2023

WARNING @daiagi PR for issue #5178 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5178

@netlify
Copy link

netlify bot commented Apr 17, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c45eb18
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/643f7e5eda3c410008ea839f
😎 Deploy Preview https://deploy-preview-5701--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Apr 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 17, 2023

AI-Generated Summary: This pull request includes significant changes to various components, additions of new components, deletion of existing components, style modifications, and updates to the pnpm-lock.yaml, locales/en.json, and package.json files. Key changes are as follows:

  1. Deletion of UploadPicture.vue and DropUpload.vue files, as well as the addition of new Vue components such as OverviewTable.vue, DragDrop, UploadDescription.vue, and UploadCompressedMedia.
  2. Updates to existing components like NeoCollapse.vue and Massmint.vue, with changes to their functionality and code organization.
  3. Modifications to styles in styles/global.scss and NeoCollapse.scss.
  4. Addition of new dependencies in pnpm-lock.yaml and package.json files, including the unzipit package.
  5. Implementation of a new Vue Composition API function named useZipFileValidator in useZipValidator.ts.
  6. Updates to user-facing text in locales/en.json.

Overall, the pull request enhances the functionality of the existing components, introduces new components for improved code organization and user experience, and updates the handling of file uploads and collections within the application.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
unzipit@1.4.3 network +1 greggman

@daiagi daiagi requested review from roiLeo and Jarsen136 and removed request for vikiival April 18, 2023 08:35
@daiagi @Jarsen136
Update components/massmint/uploadCompressedMedia/UploadCompressedMedi…
a952a6e 
…a.vue

Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
roiLeo
roiLeo approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No buefy 👌
Composition api👌

let it roll 🎢

components/shared/DragDrop.vue Outdated Show resolved Hide resolved
components/massmint/uploadCompressedMedia/useZipValidator.ts Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
components/shared/DragDrop.vue Show resolved Hide resolved
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 18, 2023
daiagi and others added 2 commits April 18, 2023 20:09
@daiagi @roiLeo
Update locales/en.json
1899d05 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@daiagi @roiLeo
Update locales/en.json
ac68dbd 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
codeclimate[bot]
codeclimate bot reviewed Apr 19, 2023
View reviewed changes
components/massmint/uploadCompressedMedia/useZipValidator.ts
const isValidFileExtension = (extension: string): boolean =>
validFormats.includes(extension)

async function checkZipFileValidity(entries: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function checkZipFileValidity has 39 lines of code (exceeds 25 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Apr 19, 2023

Code Climate has analyzed commit c45eb18 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@exezbcz
Copy link
Member

exezbcz commented Apr 19, 2023

you get this lovely tag
image

@vikiival
Copy link
Member

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 31.81 USD/KSM ~ 1.572 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x03891c31b62576be21faf8b45d123ae1afec6ebeaf795559e41e3c8ecfdea990

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 20, 2023
@vikiival vikiival merged commit c0a81b9 into main Apr 20, 2023
@vikiival vikiival deleted the feature/massmint-upload-media-zip branch April 20, 2023 20:06
This was referenced Apr 24, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
large Pull request is large paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mass Mint: step 2 - upload pictures
8 participants
@daiagi @kodabot @exezbcz @vikiival @yangwao @preschian @roiLeo @Jarsen136