Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most likely this will be pushed to production as well #5659

Merged
merged 99 commits into from
Apr 14, 2023
Merged

Most likely this will be pushed to production as well #5659

merged 99 commits into from
Apr 14, 2023

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Apr 14, 2023

Speak if you want to tell something before last push

preschian and others added 30 commits April 12, 2023 19:55
feat: removing the extra padding above the first event on mobile
@yangwao yangwao requested a review from a team as a code owner April 14, 2023 11:24
@yangwao yangwao requested review from preschian and daiagi and removed request for a team April 14, 2023 11:24
@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e1d0b5c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64395b672c594e000804475f
😎 Deploy Preview https://deploy-preview-5659--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for koda-beta ready!

Name Link
🔨 Latest commit e1d0b5c
🔍 Latest deploy log https://app.netlify.com/sites/koda-beta/deploys/64395b67b6951d0007a79181
😎 Deploy Preview https://deploy-preview-5659--koda-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@kodadot1/minimark@0.1.6-rc.0 0.0.1-rc.10...0.1.6-rc.0 None +19/-0 vikiival

@preschian
Copy link
Member

wait, checking

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 14, 2023

AI-Generated Summary: This pull request involves changes in multiple files related to updating import statements for the @kodadot1/minimark package, adding support for version 2 of @kodadot1/minimark, and improving the code readability and organization. The main changes include:

  1. Updating import paths to use specific subfolders in the @kodadot1/minimark package, such as @kodadot1/minimark/v1, @kodadot1/minimark/v2, @kodadot1/minimark/common, and @kodadot1/minimark/utils.
  2. Adding support for version 2 of interactions with the useRmrkVersion function and updating related functions to handle both version 1 and version 2.
  3. Enhancing the handling of environments and their corresponding chain lists in the utils/chain.ts file.
  4. Adding new key-value pairs in the locales/en.json file.
  5. Adjusting CSS rules, updating the import paths for Attribute, Interaction, and their related functions, and improving carousel-related components.

Overall, these updates focus on maintaining compatibility with newer versions of the @kodadot1/minimark library and improving readability and organization within the codebase.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Apr 14, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 14, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

fix: Transfer doing weird thing
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 14, 2023

AI-Generated Summary: This pull request includes updates to import statements related to the '@kodadot1/minimark' package, with most imports now coming from versioned paths ('v1', 'v2' or 'common'), enhancements to various components and styles, and improved support for different versions of RMRK interactions. Notable changes include improvements to the CarouselIndex component, Addition of a substack icon in TheFooter.vue, reorganization of code inside templates for better conditional rendering, and modifications in several utility files to handle multiple RMRK versions. Additionally, there are adjustments to chains and prefixes in the 'utils/chain.ts' file, an update of the availablePrefixes function to consider the isBeta flag, and environment-specific filtering for chains. The isProduction constant is also updated to check for hostname 'kodadot.xyz' only.

@yangwao
Copy link
Member Author

yangwao commented Apr 14, 2023

wait, checking

only this thing probably can break something?

@yangwao
Copy link
Member Author

yangwao commented Apr 14, 2023

only this thing probably can break something?

@vikiival said it's oke ;D

@preschian
Copy link
Member

preschian commented Apr 14, 2023

just want to make sure, we include this also, right? #5632

and one thing, on production, it will show rmrk and bsx, is that correct?
on beta, it will show rmrk, bsx, and ksm

otherwise, lgtm

edit: eh wait, on beta got this, is that expected? or is beta still not deployed yet?

Screenshot 2023-04-14 at 19 56 42

@yangwao
Copy link
Member Author

yangwao commented Apr 14, 2023

just want to make sure, we include this also, right? #5632

yes already merged

and one thing, on production, it will show rmrk and bsx, is that correct? on beta, it will show rmrk, bsx, and ksm

yes

edit: eh wait, on beta got this, is that expected? or is beta still not deployed yet?

not sure what I should see on picture? yet this PR is not merged :)

@preschian
Copy link
Member

not sure what I should see on picture? yet this PR is not merged :)

aahh I see 🙏🏻

@yangwao
Copy link
Member Author

yangwao commented Apr 14, 2023

will be merging this probably

@yangwao yangwao merged commit f9673ed into beta Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants