feat: popular collections #5654

floyd-li · 2023-04-13T14:20:12Z

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes Highlight popular collections in Explorer sidebar #5384
Requires deployment <>

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </bsx/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

`🤖 Generated by Copilot at 4f75b7d`

useSearchByCollections
New hook for filtering
Autumn leaves of NFTs

kodabot · 2023-04-13T14:20:16Z

WARNING @floyd-li PR for issue #5384 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5384

netlify · 2023-04-13T14:20:19Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`d4c8614`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/643fd3e63d96a20008b58783
😎 Deploy Preview	https://deploy-preview-5654--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codeclimate · 2023-04-13T14:20:53Z

components/shared/filters/modules/usePopularCollections.ts

+  return collectionMap
+}
+
+export const usePopularCollections = () => {


Function usePopularCollections has 34 lines of code (exceeds 25 allowed). Consider refactoring.

reviewpad · 2023-04-13T14:20:58Z

AI-Generated Summary: This pull request adds support for filtering gallery items by popular collections. The changes include:

updating useItemsGrid.ts and useSearchParams.ts to handle filtering by collection;
extending BreadcrumbsFilter.vue to display the selected collections and remove them from the filter;
modifying the SidebarFilter.vue to add the PopularCollections component;
adding the PopularCollections.vue component to display popular collections and handle user interaction;
introducing the constants.ts and usePopularCollections.ts files to manage the popular collections data;
adjusting the NeoSidebar.scss to update the sidebar width;
creating the collectionByIds.graphql query to fetch collection data;
updating the exploreFilters.ts store to include the collection state.

These changes allow users to filter items in the gallery by selecting specific popular collections.

reviewpad · 2023-04-13T14:23:14Z

AI-Generated Summary: This pull request introduces the ability to filter items in the ItemsGrid by popular collections. It adds a new filter section for popular collections, which when toggled, updates the items displayed in the grid. The selected collections are displayed as tags in the BreadcrumbsFilter, and the applied filters are persisted in the URL query params. This also updates the sidebar width for better visual appearance. Additionally, the changes also support filtering search by user Id and collection ids passed through the route query.

commit 1cf3faa Merge: 08c3ae1 25b914d Author: Viki Val <viktorko99@gmail.com> Date: Thu Apr 13 15:07:43 2023 +0200 Merge pull request kodadot#5635 from kodadot/feat-footer-links-2 commit 08c3ae1 Merge: 0c74a21 f7ef0bc Author: Viki Val <viktorko99@gmail.com> Date: Thu Apr 13 14:32:17 2023 +0200 Merge pull request kodadot#5648 from leo-anderson-x/5617 fix: empty `to` in SEND event commit f7ef0bc Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Thu Apr 13 20:29:25 2023 +0900 fix: empty `to` in SEND event commit 0c74a21 Merge: 108964e 7075020 Author: Viki Val <viktorko99@gmail.com> Date: Thu Apr 13 13:13:24 2023 +0200 Merge pull request kodadot#5631 from kodadot/giga-mark ⚠️

⚠️

⚠️ UPGRADED MINIMARK TO LATEST VERSION ⚠️

⚠️

⚠️ commit 7075020 Author: Viki Val <viktorko99@gmail.com> Date: Thu Apr 13 12:42:13 2023 +0200 :broom: remove unused variable commit df2bf97 Author: Viki Val <viktorko99@gmail.com> Date: Thu Apr 13 12:41:41 2023 +0200 :zap: collection on v2 commit a3f5058 Author: Viki Val <viktorko99@gmail.com> Date: Thu Apr 13 12:36:52 2023 +0200 :zap: useRMRKVersion is usable commit 25b914d Author: Prachi Darshana <prachirai00@gmail.com> Date: Wed Apr 12 20:07:35 2023 -0700 commit 7a26557 Merge: ce71bc1 108964e Author: Darshana Prachi <39299315+prachi00@users.noreply.github.com> Date: Wed Apr 12 19:46:15 2023 -0700 Merge branch 'main' into feat-footer-links-2 commit ce71bc1 Author: Prachi Darshana <prachirai00@gmail.com> Date: Wed Apr 12 19:44:53 2023 -0700 commit fb3dab0 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 19:37:25 2023 +0200 :bug: weird waringin commit e1987ec Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 19:30:27 2023 +0200 :wrench: babel-loader for minimark commit 35aa15d Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 19:10:29 2023 +0200 :??: todos commit f9df435 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 19:09:21 2023 +0200 :zap: emote works with RMRK2 commit 18c62c6 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:39 2023 +0200 :truck: new minimark in utils/shoppingActions.ts commit 6a969f9 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:37 2023 +0200 :truck: new minimark in utils/proxy.ts commit 7ec13fc Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:36 2023 +0200 :truck: new minimark in utils/mintUtils.ts commit 98d5ce1 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:35 2023 +0200 :truck: new minimark in utils/historyEvent.ts commit 96461b3 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:33 2023 +0200 :truck: new minimark in utils/format/balance.ts commit a930fad Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:32 2023 +0200 :truck: new minimark in utils/cachingStrategy.ts commit d31083b Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:31 2023 +0200 :truck: new minimark in store/assets.ts commit ab34d94 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:29 2023 +0200 :truck: new minimark in services/nftStorage.ts commit 01e0073 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:28 2023 +0200 :truck: new minimark in pages/transfer.vue commit 5758cb4 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:26 2023 +0200 :truck: new minimark in composables/useTransaction.ts commit cf0a0c8 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:25 2023 +0200 :truck: new minimark in composables/transaction/types.ts commit f9e8c75 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:24 2023 +0200 :truck: new minimark in composables/transaction/transactionSend.ts commit fa2851b Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:22 2023 +0200 :truck: new minimark in composables/transaction/transactionList.ts commit a421329 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:21 2023 +0200 :truck: new minimark in composables/transaction/transactionBuy.ts commit c4d7159 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:20 2023 +0200 :truck: new minimark in composables/transaction/transactionBurn.ts commit cb9466f Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:19 2023 +0200 :truck: new minimark in composables/transaction/mintToken/transactionMintRmrk.ts commit 33a2418 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:17 2023 +0200 :truck: new minimark in composables/transaction/mintToken/constructMeta.ts commit 80b3dc8 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:16 2023 +0200 :truck: new minimark in composables/transaction/mintCollection/transactionMintCollectionRmrk.ts commit 992418b Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:15 2023 +0200 :truck: new minimark in composables/transaction/mintCollection/constructMeta.ts commit c2133b5 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:13 2023 +0200 :truck: new minimark in composables/collectionActivity/types.ts commit 3963298 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:12 2023 +0200 :truck: new minimark in composables/collectionActivity/helpers.ts commit 841aabf Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:10 2023 +0200 :truck: new minimark in components/shared/gallery/Properties.vue commit 92a2f24 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:09 2023 +0200 :truck: new minimark in components/rmrk/utils.ts commit 2c91409 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:08 2023 +0200 :truck: new minimark in components/rmrk/types.ts commit 32c880d Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:06 2023 +0200 :truck: new minimark in components/rmrk/service/types.ts commit ecf9f9b Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:05 2023 +0200 :truck: new minimark in components/rmrk/service/scheme.ts commit 6f9c58a Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:03 2023 +0200 :truck: new minimark in components/rmrk/service/NftUtils.ts commit 9a50523 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:02 2023 +0200 :truck: new minimark in components/rmrk/Gallery/Holder/Holder.vue commit 946083b Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:53:00 2023 +0200 :truck: new minimark in components/rmrk/Gallery/History.vue commit dea612c Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:59 2023 +0200 :truck: new minimark in components/rmrk/Gallery/Flipper.vue commit 0f94bce Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:57 2023 +0200 :truck: new minimark in components/rmrk/Gallery/Appreciation.vue commit 6a66129 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:55 2023 +0200 :truck: new minimark in components/rmrk/Create/SimpleMint.vue commit f7c896f Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:53 2023 +0200 :truck: new minimark in components/rmrk/Create/CreateToken.vue commit 650f7d8 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:50 2023 +0200 :truck: new minimark in components/rmrk/Create/CreateCollection.vue commit 38056ee Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:48 2023 +0200 :truck: new minimark in components/rmrk/Create/AttributeTagInput.vue commit b551bff Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:45 2023 +0200 :truck: new minimark in components/rmrk/Create/Admin/AdminPanel.vue commit 6bd9165 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:44 2023 +0200 :truck: new minimark in components/generative/promptBuilder.ts commit ea4a1a6 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:43 2023 +0200 :truck: new minimark in components/gallery/GalleryItemButton/GalleryItemMoreActionBtn.vue commit e9ef312 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:40 2023 +0200 :truck: new minimark in components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemTransfer.vue commit 6948e73 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:38 2023 +0200 :truck: new minimark in components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemRelist.vue commit 2bdc47f Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:37 2023 +0200 :truck: new minimark in components/common/NotificationBox/useNotification.ts commit 00dbe9e Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:35 2023 +0200 :truck: new minimark in components/collection/activity/events/eventRow/common.ts commit 278b991 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:33 2023 +0200 :truck: new minimark in components/collection/activity/events/Events.vue commit bc29d2a Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:32 2023 +0200 :truck: new minimark in components/collection/activity/ActivityChart.vue commit 59bb778 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:30 2023 +0200 :truck: new minimark in components/collection/activity/Activity.vue commit 98b35a0 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:28 2023 +0200 :truck: new minimark in components/bsx/Offer/OffersUserTable.vue commit 5f31167 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:26 2023 +0200 :truck: new minimark in components/bsx/Offer/OfferTable.vue commit 185cb10 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:24 2023 +0200 :truck: new minimark in components/bsx/Create/CreateToken.vue commit 302db09 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:22 2023 +0200 :truck: new minimark in components/bsx/Create/CreateCollection.vue commit 7822688 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:21 2023 +0200 :truck: new minimark in components/bsx/Asset/AssetTable.vue commit d95682f Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:52:18 2023 +0200 :truck: new minimark in components/accounts/utils.ts commit ae9c5e8 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 18:51:45 2023 +0200 :arrow_up: @kodadot1/minimark commit c61f4a8 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 16:58:24 2023 +0200 :arrow_up: @kodadot1/minimark commit 108964e Merge: 8a0a68f 350563c Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 16:25:23 2023 +0200 Merge pull request kodadot#5621 from leo-anderson-x/5612 feat: larger height of gallery tab item container on mobile commit 8a0a68f Merge: 6315c5a bd93680 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 16:24:16 2023 +0200 Merge pull request kodadot#5620 from Jarsen136/issue-5618 fix: Show rmrk2 on landing - beta.kodadot.xyz commit 350563c Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Wed Apr 12 21:46:55 2023 +0900 feat: larger height of gallery tab item container on mobile commit bd93680 Author: Jarsen <695552027@qq.com> Date: Wed Apr 12 20:46:34 2023 +0800 fix: Show rmrk2 on landing - beta.kodadot.xyz commit 6315c5a Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:32:40 2023 +0200 removing windows as it costs 2x minutes no one has windows, right? commit c1730f4 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:31:22 2023 +0200 build me against beta & hyper-jpeg commit f91ae36 Merge: ae46dab 2b48024 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:25:22 2023 +0200 Merge pull request kodadot#5598 from kodadot/fix/redirection-when-listed-true fix: redirection when listed=true commit ae46dab Merge: 954b4bd e265509 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:22:29 2023 +0200 Merge pull request kodadot#5601 from leo-anderson-x/5582 fix: no margin bottom on collection items commit 954b4bd Merge: cd46d02 1064e31 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:19:10 2023 +0200 Merge pull request kodadot#5604 from Jarsen136/issue-5592 fix: Remove appending ?page=1 commit cd46d02 Merge: f359914 662e79b Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:17:51 2023 +0200 Merge pull request kodadot#5581 from daiagi/follow-up-notifications Follow up notifications commit 662e79b Merge: b92bb03 f359914 Author: Luke Fishman <daiagi@gmail.com> Date: Wed Apr 12 18:16:04 2023 +0700 Merge branch 'main' into follow-up-notifications commit f359914 Merge: 922eb95 ac81a69 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:14:35 2023 +0200 Merge pull request kodadot#5607 from daiagi/Flippers-all-showing-same-activity 🐛 flippers all showing same commit b92bb03 Merge: 5426161 922eb95 Author: Luke Fishman <daiagi@gmail.com> Date: Wed Apr 12 18:12:42 2023 +0700 Merge branch 'main' into follow-up-notifications commit 922eb95 Merge: 56c0b70 b04d44b Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:05:05 2023 +0200 Merge pull request kodadot#5610 from roiLeo/fix/identity/inputLength 🔧 identityForm inputs length commit 56c0b70 Merge: afbf287 d021350 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 13:04:08 2023 +0200 Merge pull request kodadot#5608 from daiagi/lazy-load-owner-insights ⚡️ Activity: lazy load owner insights commit 5426161 Merge: 83291a9 afbf287 Author: daiagi <daiagi@gmail.com> Date: Wed Apr 12 18:03:20 2023 +0700 Merge branch 'main' of https://github.com/kodadot/nft-gallery into follow-up-notifications commit ac81a69 Merge: fb34222 afbf287 Author: Viki Val <viktorko99@gmail.com> Date: Wed Apr 12 13:02:23 2023 +0200 Merge branch 'main' into Flippers-all-showing-same-activity commit afbf287 Merge: ad289c4 e9b3713 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 12:30:25 2023 +0200 Merge pull request kodadot#5609 from roiLeo/chore/rmrk/creative 🔥 remove creative minting commit ad289c4 Merge: 662272c b283f53 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 12:29:54 2023 +0200 Merge pull request kodadot#5594 from kodadot/feat/set-prefix-to-localstorage fix: set prefix to localStorage commit 662272c Merge: ca014b9 64e12ef Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Wed Apr 12 12:26:53 2023 +0200 Merge pull request kodadot#5613 from kodadot/fix/get-images-on-explorer-collection-ksm fix: get images on explorer collectibles for ksm commit 64e12ef Author: Preschian F <preschian@users.noreply.github.com> Date: Wed Apr 12 17:11:56 2023 +0700 fix: get images on explorer collectibles for ksm commit b04d44b Author: roiLeo <medina.leo42@gmail.com> Date: Wed Apr 12 10:47:04 2023 +0200 🔧 identityForm inputs length commit 097a8a6 Author: roiLeo <medina.leo42@gmail.com> Date: Wed Apr 12 10:46:23 2023 +0200 🔧 identityForm inputs length commit d021350 Author: daiagi <daiagi@gmail.com> Date: Wed Apr 12 15:45:56 2023 +0700 ⚡️ keep scroll position on ownerInsights tab change commit bd3169a Author: roiLeo <medina.leo42@gmail.com> Date: Wed Apr 12 10:45:56 2023 +0200 🔧 identityForm inputs length commit 1025862 Author: daiagi <daiagi@gmail.com> Date: Wed Apr 12 15:16:33 2023 +0700 🐛 lazy load only displayed flips commit e0f1228 Author: daiagi <daiagi@gmail.com> Date: Wed Apr 12 15:14:12 2023 +0700 ⚡️ lazy load NFTDetailsDropdown commit e9b3713 Author: roiLeo <medina.leo42@gmail.com> Date: Wed Apr 12 10:02:04 2023 +0200 🔥 remove creative minting commit 5308343 Author: daiagi <daiagi@gmail.com> Date: Wed Apr 12 13:27:55 2023 +0700 ⚡️ Activity: lazy load owner insights commit 2b48024 Merge: 542fee2 ca014b9 Author: Preschian Febryantara <preschian@users.noreply.github.com> Date: Wed Apr 12 12:56:12 2023 +0700 Merge branch 'main' of github.com:kodadot/nft-gallery into fix/redirection-when-listed-true commit 542fee2 Author: Preschian Febryantara <preschian@users.noreply.github.com> Date: Wed Apr 12 12:49:08 2023 +0700 fix: no need redirect in replaceUrl function commit b283f53 Author: Preschian Febryantara <preschian27@gmail.com> Date: Wed Apr 12 12:26:28 2023 +0700 fix: navbar selector commit 6ca8208 Merge: da66d31 ca014b9 Author: Preschian Febryantara <preschian27@gmail.com> Date: Wed Apr 12 11:33:00 2023 +0700 Merge branch 'main' of github.com:kodadot/nft-gallery into feat/set-prefix-to-localstorage commit fb34222 Author: daiagi <daiagi@gmail.com> Date: Wed Apr 12 06:38:20 2023 +0700 🐛 flippers all showing same commit 83291a9 Merge: 79df503 ca014b9 Author: daiagi <daiagi@gmail.com> Date: Wed Apr 12 05:50:30 2023 +0700 Merge branch 'main' of https://github.com/kodadot/nft-gallery into follow-up-notifications commit 79df503 Author: daiagi <daiagi@gmail.com> Date: Wed Apr 12 05:50:15 2023 +0700 🐛 text overflow commit 1064e31 Author: Jarsen <695552027@qq.com> Date: Wed Apr 12 01:56:31 2023 +0800 fix: remove auto import commit a1f7e44 Author: Jarsen <695552027@qq.com> Date: Wed Apr 12 01:54:08 2023 +0800 fix: Remove appending ?page=1 commit ca014b9 Merge: 5943df0 eb3af71 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 18:34:48 2023 +0200 Merge pull request kodadot#5602 from kodadot/5535-final-prefix 5535 final prefix commit eb3af71 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 17:14:29 2023 +0200 :bug: unable to redirect rmrk2 into kodadot commit aa8ac7f Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 17:13:45 2023 +0200 :truck: moved subsquid/rmrk2 into subsquid/ksm commit 46e87c9 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 17:12:13 2023 +0200 :truck: moved subsquid/rmrk2 into subsquid/ksm commit af055cb Author: daiagi <daiagi@gmail.com> Date: Tue Apr 11 20:04:46 2023 +0700 close notification box whenchanging chain commit fc6e70a Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 15:04:31 2023 +0200 :broom: useless conditional commit 3d1c021 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:50:11 2023 +0200 :truck: small renames commit ec249a6 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:45:19 2023 +0200 :truck: rename chain-rmrk2 to chain-ksm in components/massmint/useMassMint.ts commit f8f0b8a Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:45:17 2023 +0200 :truck: rename chain-rmrk2 to chain-ksm in components/items/ItemsGrid/useItemsGrid.ts commit 12b22f8 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:45:16 2023 +0200 :truck: rename chain-rmrk2 to chain-ksm in components/gallery/useGalleryItem.ts commit 46cd9dc Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:45:13 2023 +0200 :truck: rename chain-rmrk2 to chain-ksm in components/carousel/utils/useCarousel.ts commit 23bc3fc Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:40:55 2023 +0200 :heavy_minus_sign: netlify-lambda commit 617c393 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:39:56 2023 +0200 :arrow_up: @kodadot1/vuex-options commit cf56a06 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:31 2023 +0200 :truck: rename rmrk2 to ksm in utils/queryPathResolver.ts commit 4f46ac9 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:30 2023 +0200 :truck: rename rmrk2 to ksm in utils/prefix.ts commit 20e2e75 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:28 2023 +0200 :truck: rename rmrk2 to ksm in utils/config/types.ts commit 0489c4c Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:27 2023 +0200 :truck: rename rmrk2 to ksm in utils/config/defineApolloConfig.ts commit a494b42 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:25 2023 +0200 :truck: rename rmrk2 to ksm in utils/api/bsx/query.ts commit 7c75cd8 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:23 2023 +0200 :truck: rename rmrk2 to ksm in pages/series-insight.vue commit 04d9312 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:22 2023 +0200 :truck: rename rmrk2 to ksm in middleware/prefix.ts commit f5bb3bd Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:19 2023 +0200 :truck: rename rmrk2 to ksm in libs/static/src/chains.ts commit 79f6d02 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:18 2023 +0200 :truck: rename rmrk2 to ksm in composables/useNft.ts commit 72e7e85 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:16 2023 +0200 :truck: rename rmrk2 to ksm in composables/useChain.ts commit aa0673e Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:14 2023 +0200 :truck: rename rmrk2 to ksm in composables/transaction/transactionSend.ts commit 7a5b9c8 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:13 2023 +0200 :truck: rename rmrk2 to ksm in composables/transaction/transactionMintToken.ts commit c7908b0 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:11 2023 +0200 :truck: rename rmrk2 to ksm in composables/transaction/transactionMintCollection.ts commit 3260f3b Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:09 2023 +0200 :truck: rename rmrk2 to ksm in composables/transaction/transactionList.ts commit 9957798 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:06 2023 +0200 :truck: rename rmrk2 to ksm in composables/transaction/transactionBuy.ts commit 9ed76b7 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:03 2023 +0200 :truck: rename rmrk2 to ksm in composables/transaction/transactionBurn.ts commit 75a6166 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:02 2023 +0200 :truck: rename rmrk2 to ksm in composables/transaction/mintCollection/constructMeta.ts commit a9f0198 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:35:00 2023 +0200 :truck: rename rmrk2 to ksm in composables/collectionActivity/helpers.ts commit 173db2f Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:59 2023 +0200 :truck: rename rmrk2 to ksm in components/navbar/StatsDropdown.vue commit 8cf9b68 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:57 2023 +0200 :truck: rename rmrk2 to ksm in components/navbar/ProfileDropdown.vue commit 069612f Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:56 2023 +0200 :truck: rename rmrk2 to ksm in components/navbar/NavbarExploreOptions.vue commit dc0e312 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:54 2023 +0200 :truck: rename rmrk2 to ksm in components/landing/LandingPage.vue commit b74ebbc Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:53 2023 +0200 :truck: rename rmrk2 to ksm in components/items/ItemsGrid/useItemsGrid.ts commit f00598f Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:51 2023 +0200 :truck: rename rmrk2 to ksm in components/gallery/GalleryItemTabsPanel/GalleryItemTabsPanel.vue commit 3e65096 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:50 2023 +0200 :truck: rename rmrk2 to ksm in components/gallery/GalleryItemTabsPanel/GalleryItemActivityTable.vue commit 7a20d6d Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:48 2023 +0200 :truck: rename rmrk2 to ksm in components/gallery/GalleryItemDescription.vue commit fdb7b6b Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:47 2023 +0200 :truck: rename rmrk2 to ksm in components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemOffer.vue commit d61cb7a Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:45 2023 +0200 :truck: rename rmrk2 to ksm in components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemBuy.vue commit b4df07c Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:34:43 2023 +0200 :truck: rename rmrk2 to ksm in components/carousel/utils/useCarousel.ts commit 39a6363 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:33:09 2023 +0200 :alien: deprecating rmrk2 prefix commit d818ff2 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:32:14 2023 +0200 :truck: rename rmrk2 to ksm commit 7e9c3ac Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:31:34 2023 +0200 :wastebasket: bye for rmrk2 commit 0ad313b Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:27:22 2023 +0200 :coffin: last words from rmrk2 commit 38f6d3b Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:25:43 2023 +0200 :wastebasket: from chain.config commit b492458 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 14:23:31 2023 +0200 :wastebasket: remove rmrk2 from static commit e265509 Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Tue Apr 11 21:03:18 2023 +0900 fix: no margin bottom on collection items commit cd95547 Author: Preschian F <preschian27@gmail.com> Date: Tue Apr 11 17:31:06 2023 +0700 refactor: swap order of condition Co-authored-by: roiLeo <medina.leo42@gmail.com> commit da66d31 Author: Preschian F <preschian27@gmail.com> Date: Tue Apr 11 17:04:41 2023 +0700 refactor: default prefix Co-authored-by: roiLeo <medina.leo42@gmail.com> commit 83fa86b Author: Preschian F <preschian27@gmail.com> Date: Tue Apr 11 16:57:50 2023 +0700 fix: redirection when listed=true commit 5943df0 Merge: b3744ba db8a188 Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 11:17:04 2023 +0200 Merge pull request kodadot#5580 from kodadot/renovate/bumped-minor-version-of-packages commit b3744ba Merge: 237562b 0c07dec Author: Viki Val <viktorko99@gmail.com> Date: Tue Apr 11 11:16:27 2023 +0200 Merge pull request kodadot#5569 from kodadot/feat-empty-state commit 0e2222c Author: Preschian F <preschian27@gmail.com> Date: Tue Apr 11 14:41:08 2023 +0700 feat: set prefix to localStorage commit ca9be45 Merge: 82afeb1 5943df0 Author: daiagi <daiagi@gmail.com> Date: Tue Apr 11 14:06:11 2023 +0700 Merge branch 'main' of https://github.com/kodadot/nft-gallery into follow-up-notifications commit db8a188 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Apr 11 06:06:36 2023 +0000 [skip netlify] Update Bumped minor version of packages commit 0c07dec Author: Prachi Darshana <prachirai00@gmail.com> Date: Mon Apr 10 14:26:59 2023 -0700 center align commit 32a8a34 Author: Darshana Prachi <39299315+prachi00@users.noreply.github.com> Date: Mon Apr 10 14:23:21 2023 -0700 Update components/collection/activity/events/Events.vue Co-authored-by: Luke Fishman <daiagi@gmail.com> commit 237562b Merge: f1dc104 be6d6e6 Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 21:48:03 2023 +0200 Merge pull request kodadot#5559 from Jarsen136/issue-5552 fix: Line in the middle after opening wallet dialog commit be6d6e6 Merge: da33172 f1dc104 Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 21:40:51 2023 +0200 Merge branch 'main' into issue-5552 commit f1dc104 Merge: 0a8f1d5 2352b83 Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 21:36:33 2023 +0200 Merge pull request kodadot#5557 from Jarsen136/issue-5550 fix: Menu on mobile broken commit 0a8f1d5 Merge: 6c93e62 f202dca Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 21:35:25 2023 +0200 Merge pull request kodadot#5558 from Jarsen136/issue-5551 fix: Copy link should be on the item page commit 6c93e62 Merge: 69113c4 ceab7e6 Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 21:33:33 2023 +0200 Merge pull request kodadot#5571 from kodadot/feat-scroll-btn commit 69113c4 Merge: f560836 b563a54 Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 21:32:31 2023 +0200 Merge pull request kodadot#5570 from kodadot/feat-footer-links commit f560836 Merge: fa8d563 84f3cab Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 21:31:22 2023 +0200 Merge pull request kodadot#5564 from leo-anderson-x/5545 feat: make only 2 filters active by default commit fa8d563 Merge: 3cfdd3f 4d6d9f6 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Mon Apr 10 20:58:40 2023 +0200 Merge pull request kodadot#5591 from Jarsen136/issue-5536 fix: Add whitelist for rmrk2.kodadot.xyz commit 4d6d9f6 Author: Jarsen <695552027@qq.com> Date: Tue Apr 11 00:59:18 2023 +0800 fix: add rmrk commit 19f46b3 Author: Jarsen <695552027@qq.com> Date: Tue Apr 11 00:54:04 2023 +0800 fix: Add whitelist for rmrk2.kodadot.xyz commit 3cfdd3f Merge: 041df39 0490910 Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Mon Apr 10 18:19:50 2023 +0200 Merge pull request kodadot#5589 from Jarsen136/issue-5495 fix: Switch chain to rmrk2 on rmrk2.kodadot.xyz commit 0490910 Author: Jarsen <695552027@qq.com> Date: Mon Apr 10 23:59:02 2023 +0800 fix: Switch chain to rmrk2 on rmrk2.kodadot.xyz commit 041df39 Merge: f9e84e3 4a85c3f Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 15:32:51 2023 +0200 Merge pull request kodadot#5563 from kodadot/feat-neo-modal commit 4a85c3f Merge: d4ce189 f9e84e3 Author: Viki Val <viktorko99@gmail.com> Date: Mon Apr 10 15:24:10 2023 +0200 Merge branch 'main' into feat-neo-modal commit 82afeb1 Merge: 8168689 f9e84e3 Author: Luke Fishman <daiagi@gmail.com> Date: Mon Apr 10 15:09:18 2023 +0300 Merge branch 'main' into follow-up-notifications commit f9e84e3 Merge: 2e4fd7d 812330e Author: Matej yangwao <5887929+yangwao@users.noreply.github.com> Date: Mon Apr 10 13:56:30 2023 +0200 Merge pull request kodadot#5546 from leo-anderson-x/5359 feat: float filter button on mobile collection activity page commit 8168689 Author: daiagi <daiagi@gmail.com> Date: Mon Apr 10 15:38:17 2023 +0700 Make Text Bold Again commit c2c04c1 Author: daiagi <daiagi@gmail.com> Date: Mon Apr 10 15:22:41 2023 +0700 text overflow and tooltip actiovation area commit 358b0b4 Author: daiagi <daiagi@gmail.com> Date: Mon Apr 10 14:49:45 2023 +0700 💄 visual touchupd commit 63f3944 Author: daiagi <daiagi@gmail.com> Date: Mon Apr 10 11:49:06 2023 +0700 add loading tip commit 9e1eef1 Author: daiagi <daiagi@gmail.com> Date: Mon Apr 10 11:19:15 2023 +0700 a little rearangment commit 7c2c2f6 Author: daiagi <daiagi@gmail.com> Date: Mon Apr 10 11:05:53 2023 +0700 make it work across chains, simplify code commit b563a54 Merge: 4401c11 2e4fd7d Author: Darshana Prachi <39299315+prachi00@users.noreply.github.com> Date: Sun Apr 9 17:53:30 2023 -0700 Merge branch 'main' into feat-footer-links commit 4401c11 Author: Prachi Darshana <prachirai00@gmail.com> Date: Sun Apr 9 17:53:03 2023 -0700 footer changes two columns commit 70d9dde Merge: b54574f 2e4fd7d Author: Darshana Prachi <39299315+prachi00@users.noreply.github.com> Date: Sun Apr 9 17:43:33 2023 -0700 Merge branch 'main' into feat-empty-state commit b54574f Author: Prachi Darshana <prachirai00@gmail.com> Date: Sun Apr 9 17:43:18 2023 -0700 font size changes commit ceab7e6 Merge: 0209837 2e4fd7d Author: Darshana Prachi <39299315+prachi00@users.noreply.github.com> Date: Sun Apr 9 17:37:39 2023 -0700 Merge branch 'main' into feat-scroll-btn commit 0209837 Author: Prachi Darshana <prachirai00@gmail.com> Date: Sun Apr 9 17:36:57 2023 -0700 css fix commit 812330e Merge: 02a6528 72e9024 Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Sun Apr 9 22:33:07 2023 +0900 Merge branch 'main' into 5359 commit 02a6528 Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Sun Apr 9 22:26:55 2023 +0900 Update components/explore/MobileControls.vue Co-authored-by: Luke Fishman <daiagi@gmail.com> commit 6b5a0ee Author: Prachi Darshana <prachirai00@gmail.com> Date: Sat Apr 8 17:59:15 2023 -0700 commit 3349857 Author: Prachi Darshana <prachirai00@gmail.com> Date: Sat Apr 8 17:51:22 2023 -0700 commit bf3923a Author: Prachi Darshana <prachirai00@gmail.com> Date: Sat Apr 8 17:44:31 2023 -0700 check commit 3bf6a1b Author: Prachi Darshana <prachirai00@gmail.com> Date: Sat Apr 8 17:42:35 2023 -0700 commit d4ce189 Author: Prachi Darshana <prachirai00@gmail.com> Date: Sat Apr 8 16:43:09 2023 -0700 fixes commit b2d20fe Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Sat Apr 8 17:19:48 2023 +0900 extract `activeFilters` to a composable commit 85eb6f0 Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Sat Apr 8 16:51:12 2023 +0900 move `FilterFloatButton` under /collection/activity folder commit da33172 Author: Jarsen <695552027@qq.com> Date: Sat Apr 8 11:27:31 2023 +0800 fix: fullscreen image preview commit c8f5b7e Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Sat Apr 8 11:39:18 2023 +0900 use v-else instead commit ac04e38 Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Sat Apr 8 11:38:14 2023 +0900 remove unused css variables import commit 43b2388 Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Sat Apr 8 11:37:27 2023 +0900 remove space after the burger menu is not displayed commit 84f3cab Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Sat Apr 8 10:43:06 2023 +0900 feat: make only 2 filters active by default commit c900779 Author: Prachi Darshana <prachirai00@gmail.com> Date: Fri Apr 7 17:43:20 2023 -0700 refactor commit f404f86 Author: Prachi Darshana <prachirai00@gmail.com> Date: Fri Apr 7 17:40:29 2023 -0700 remove useless import commit e02f44e Merge: 05f5033 6f596ae Author: Darshana Prachi <39299315+prachi00@users.noreply.github.com> Date: Fri Apr 7 17:38:52 2023 -0700 Merge branch 'main' into feat-neo-modal commit 05f5033 Author: Prachi Darshana <prachirai00@gmail.com> Date: Fri Apr 7 17:36:57 2023 -0700 commit 736a086 Author: Jarsen <695552027@qq.com> Date: Sat Apr 8 02:33:12 2023 +0800 fix: Line in the middle after opening wallet dialog commit f202dca Author: Jarsen <695552027@qq.com> Date: Sat Apr 8 02:15:14 2023 +0800 fix: Copy link should be on the item page commit 2352b83 Author: Jarsen <695552027@qq.com> Date: Sat Apr 8 01:53:42 2023 +0800 fix: Menu on mobile broken commit 215a635 Merge: e43b2b8 6f596ae Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Fri Apr 7 21:36:15 2023 +0900 Merge branch 'main' into 5359 commit e43b2b8 Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Fri Apr 7 21:33:15 2023 +0900 fix: avoid space in template commit 681e725 Author: Leo Anderson <128157824+leo-anderson-x@users.noreply.github.com> Date: Fri Apr 7 21:12:43 2023 +0900 feat: float filter button on mobile collection activity page

codeclimate · 2023-04-13T14:27:06Z

composables/useActiveRouterFilters.ts

@@ -0,0 +1,18 @@
+export default function useActiveRouterFilters() {


Function useActiveRouterFilters has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2023-04-13T14:27:06Z

nuxt.config.js

@@ -379,10 +379,17 @@ export default defineNuxtConfig({
        query: { compact: true },
      })

+      config.module.rules.push({


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-04-13T14:27:07Z

libs/static/src/names.ts


-export const NAMES: Record<BackwardPrefix, string> = {
+export const NAMES: Record<Prefix, string> = {


Similar blocks of code found in 2 locations. Consider refactoring.

reviewpad · 2023-04-13T14:28:22Z

AI-Generated Summary: This pull request includes a variety of changes across multiple files, mainly focusing on updates to import statements, refactoring to use the Vue 3 Composition API, and improving user experience with updated condition checks and better styling. Some notable changes include:

Updating import paths for the Interaction, Attribute, and empty* modules to their respective new locations within @kodadot1/minimark, streamlining the code organization.
Refactoring several components to use the Vue 3 Composition API and reactive features, simplifying code and making it easier to read and maintain.
Updating numerous condition checks and statements to use the new 'ksm' value as the chain prefix, ensuring proper functionality and consistency across the application.
Introducing new components like FilterFloatButton.vue and enhancing existing components with better styling, handling of pagination, and improved display of messages, particularly for mobile devices.
Removing no longer needed or outdated functionalities, such as certain components, functions, and types, improving maintainability and code cleanliness.

These changes contribute to improvements in code quality, user experience, and overall maintainability of the application.

floyd-li · 2023-04-13T14:29:45Z

known issues: to count the total owners of the collection, i made the query to get all the nfts of the collection with currentOwner. it's really a big query. seems we may need to add a filed ownerCount like nftCount?

reviewpad · 2023-04-13T14:31:22Z

AI-Generated Summary: This pull request introduces changes to support the filtering of items by collections. The update adds a collection query and route query parameters to the ItemsGrid component. It also includes a new filter component called PopularCollections, which displays a list of popular collections to filter items by. Users can now filter items by multiple collections in the "Search" and "Explore" pages. Additionally, the sidebar's width has been increased to accommodate the new filter component.

codeclimate · 2023-04-18T11:55:14Z

components/shared/filters/modules/usePopularCollections.ts

+  }[]
+}
+
+export const usePopularCollections = () => {


Function usePopularCollections has 30 lines of code (exceeds 25 allowed). Consider refactoring.

@floyd-li can you have look on this before we merge?

@yangwao done

yangwao · 2023-04-18T13:49:21Z

hey why it shows elsewhere than explorer, like I can see it on this collection?

floyd-li · 2023-04-18T16:32:48Z

hey why it shows elsewhere than explorer, like I can see it on this collection?

fixed

exezbcz · 2023-04-18T18:16:21Z

there is a bit weird scrolling when there are less items - see the video, I am mostly scrolling and you have to scroll several times to get to the bottom

Screen.Recording.2023-04-18.at.20.00.34.mov

otherwise I think the major things were solved

daiagi

last fixes

daiagi · 2023-04-19T04:06:03Z

components/shared/BreadcrumbsFilter.vue

+  collectionArray.value?.filter((x) =>
+    collectionIdList.value?.find((id) => x.id === id)


please don't use name like x for variables

daiagi · 2023-04-19T04:06:43Z

components/shared/BreadcrumbsFilter.vue

+)
+
+const removeCollection = (id: string) => {
+  const ids = collections.value.filter((x) => x.id !== id).map((x) => x.id)


x variable name

daiagi · 2023-04-19T04:08:43Z

components/shared/filters/SidebarFilter.vue

@@ -4,6 +4,10 @@
      <EventTypeFilter v-if="isCollectionActivityTab" expanded fluid-padding />
      <StatusFilter v-else expanded fluid-padding />
      <PriceFilter v-if="!isCollectionActivityTab" fluid-padding />
+      <PopularCollections
+        v-if="!isCollectionActivityTab && !isCollectionDetail"


maybe it will be clearer to choose when it is displayed
rather then choosing when it isn't

daiagi · 2023-04-19T04:10:07Z

components/shared/filters/modules/PopularCollections.vue

+const { $store } = useNuxtApp()
+
+const getChainName = (chain: string): string => {
+  return availableChains.value.find((x) => x.value === chain)?.text || ''


x var name

daiagi · 2023-04-19T04:21:42Z

components/items/ItemsGrid/utils/useSearchParams.ts

+        return [
+          {
+            collection: {
+              id_in: (route.query.collections as string).split(','),


you have this kind of string manipulation bit spread all over each time you need to read/write collection from the url

please create a util function and avoid repetition

daiagi · 2023-04-19T04:26:34Z

components/shared/filters/modules/PopularCollections.vue

+const getSearchParam = () => {
+  if (props.dataModel === 'query') {
+    checkedCollections.value =
+      (route.query?.collections as string)?.split(',').filter((x) => !!x) || []


x variable name

daiagi · 2023-04-19T04:41:22Z

components/shared/filters/modules/usePopularCollections.ts

+  watch(loadingMap, (val) => {
+    Object.keys(val).forEach((key, index) => {
+      if (!loadingMap[key].value) {
+        collections.value = handleResult(collections.value, resArr.value, index)
+        collectionArray.value = collections.value
+        delete loadingMap[key]


don't use delete

seems to me this will be quite easier if you create an object
that looks like

{ [chain]: { loading: boolean, data: queryResult } }

and just process the data of the corrosponding loading when it turns to false

@daiagi hmmm but in this way we may need an extra field to flag if this chain's data has been handled. wdyt?

Why?
You watch the loading, and when it's done you process the corrosponding data and push the results to the output array that the vue components use

yes, i watch the chainData object, and there's a for each loop in the handler, if we do not add the flag it will process the data repeated🤔️ did i make sence?

watch(chainData, (val) => { Object.keys(val).forEach((chain, index) => { ... })

Yeah I see your point.
I think it will result in cleaner simpler code
But it's just a suggestion...

daiagi · 2023-04-19T04:43:30Z

components/shared/filters/modules/usePopularCollections.ts

+  const newCollections =
+    result[index].value?.collectionEntities?.map((item) => ({
+      ...item,
+      owners: new Set(item.nfts.map((x) => x.currentOwner)).size,


x var name

yangwao · 2023-04-19T10:19:32Z

Let's reflect @daiagi code review comments @floyd-li and it's ok to merge for me! :)

codeclimate · 2023-04-19T11:16:18Z

components/shared/filters/modules/usePopularCollections.ts

+  }[]
+}
+
+export const usePopularCollections = () => {


Function usePopularCollections has 26 lines of code (exceeds 25 allowed). Consider refactoring.

components/shared/filters/modules/PopularCollections.vue

codeclimate · 2023-04-19T11:44:02Z

Code Climate has analyzed commit d4c8614 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

daiagi

Looking good now.
Thank you 👌👌

exezbcz · 2023-04-19T14:46:48Z

yes, letsgo

yangwao · 2023-04-20T10:51:32Z

finally we are merging 😍 it took while 👀
pay 70 usd

looking forward for another pull-requests!

yangwao · 2023-04-20T10:51:46Z

😍 Perfect, I’ve sent the payout
💵 $70 @ 34.26 USD/KSM ~ 2.043 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0x81b0eccec02656c4275a9e0dc2bd27b6d3bee5ed54ebbb26463467b5ff52711c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

floyd-li added 9 commits April 10, 2023 13:59

feat: init

42a18c1

feat(wip): popular collections

77946a3

feat(wip): add collection filter

11b36f6

feat(wip): popular collection

809c01d

feat: display fix

320c656

feat: handle redirect

3c30108

feat: count owners

9320fe3

feat: remove test data

17459b6

feat: add mobile filter

94ee766

floyd-li requested a review from a team as a code owner April 13, 2023 14:20

floyd-li requested review from daiagi and Jarsen136 and removed request for a team April 13, 2023 14:20

codeclimate bot reviewed Apr 13, 2023

View reviewed changes

reviewpad bot added medium Pull request is medium waiting-for-review labels Apr 13, 2023

floyd-li added 2 commits April 13, 2023 22:24

feat: add query params

f0f5221

codeclimate bot reviewed Apr 13, 2023

View reviewed changes

reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Apr 13, 2023

Merge branch 'main' into feat/popular-collections

936f31b

reviewpad bot removed the large Pull request is large label Apr 13, 2023

feat: collection name sort

5c663ea

codeclimate bot reviewed Apr 18, 2023

View reviewed changes

Merge branch 'main' into feat/popular-collections

5444839

yangwao mentioned this pull request Apr 18, 2023

New beta batch things for test #5715

Merged

floyd-li added 3 commits April 18, 2023 21:56

feat: hide popular collection in detail

e6c1614

refactor: fix codeclimate

48d2dea

refactor: fix codeclimate

6861864

daiagi suggested changes Apr 19, 2023

View reviewed changes

floyd-li added 4 commits April 19, 2023 18:29

fix: update var name

9c7163b

fix: code review suggestion

3fcf73b

refactor: get collection from query string

a842b7e

refactor: use isExploreItems

63e9d13

codeclimate bot reviewed Apr 19, 2023

View reviewed changes

floyd-li commented Apr 19, 2023

View reviewed changes

components/shared/filters/modules/PopularCollections.vue Outdated Show resolved Hide resolved

Update components/shared/filters/modules/PopularCollections.vue

d4c8614

daiagi added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Apr 19, 2023

daiagi approved these changes Apr 19, 2023

View reviewed changes

exezbcz added the S-visual-ok-✅ label Apr 19, 2023

yangwao merged commit 73e433e into kodadot:main Apr 20, 2023

yangwao added the paid pull-request has been paid label Apr 20, 2023

roiLeo mentioned this pull request May 21, 2023

Sort popular collection alphabetically #5680

Closed

		@@ -0,0 +1,18 @@
		export default function useActiveRouterFilters() {


		export const NAMES: Record<BackwardPrefix, string> = {
		export const NAMES: Record<Prefix, string> = {

		collectionArray.value?.filter((x) =>
		collectionIdList.value?.find((id) => x.id === id)

feat: popular collections #5654

feat: popular collections #5654

Conversation

floyd-li commented Apr 13, 2023 • edited by ghost Loading

PR Type

Context

Before submitting pull request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot 📸

🤖 Generated by Copilot at 4f75b7d

kodabot commented Apr 13, 2023

netlify bot commented Apr 13, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

codeclimate bot Apr 13, 2023

Choose a reason for hiding this comment

reviewpad bot commented Apr 13, 2023

reviewpad bot commented Apr 13, 2023

codeclimate bot Apr 13, 2023

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2023

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2023

Choose a reason for hiding this comment

reviewpad bot commented Apr 13, 2023

floyd-li commented Apr 13, 2023

reviewpad bot commented Apr 13, 2023

codeclimate bot Apr 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yangwao commented Apr 18, 2023

floyd-li commented Apr 18, 2023

exezbcz commented Apr 18, 2023

daiagi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daiagi Apr 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yangwao commented Apr 19, 2023

codeclimate bot Apr 19, 2023

Choose a reason for hiding this comment

codeclimate bot commented Apr 19, 2023

daiagi left a comment

Choose a reason for hiding this comment

exezbcz commented Apr 19, 2023

yangwao commented Apr 20, 2023

yangwao commented Apr 20, 2023

floyd-li commented Apr 13, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at 4f75b7d`

netlify bot commented Apr 13, 2023 •

edited

Loading

daiagi Apr 19, 2023 •

edited

Loading