Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5316 payments #5317

Merged
merged 6 commits into from
Mar 21, 2023
Merged

5316 payments #5317

merged 6 commits into from
Mar 21, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Mar 21, 2023

It's really 💩 fix but should work

What was happening?

From url we checked usd amount, multiplied with ksm value (which is 0 when component is created)
the result of multiply was Infinity and that failed to sign the transaction.

  • 🐛 making props in disabled input optional
  • 🏷️ properly typed
  • 💩 resolve usd value to KSM

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

BETA:

Screenshot 2023-03-21 at 15 14 22

PR:

Screenshot 2023-03-21 at 15 14 05

@vikiival vikiival requested a review from a team as a code owner March 21, 2023 14:10
@vikiival vikiival requested review from preschian and roiLeo and removed request for a team March 21, 2023 14:10
@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 17373b5
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6419d925f3a6a70008bc3f60
😎 Deploy Preview https://deploy-preview-5317--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't possible without timeout? maybe watcher

@Jarsen136
Copy link
Contributor

isn't possible without timeout? maybe watcher

I agree.

Or we could try something like this, to update data after fetching the ksm price.

this.fiatStore.fetchFiatPrice().then(() => {
  this.onUSDFieldChange()
})

@vikiival
Copy link
Member Author

By @roiLeo via watcher in 2fc4741

By @Jarsen136 via then in 994effc

pages/transfer.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Mar 21, 2023

Code Climate has analyzed commit 17373b5 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 6a23c8b into main Mar 21, 2023
@vikiival vikiival deleted the 5316-payments branch March 21, 2023 16:39
@yangwao
Copy link
Member

yangwao commented Mar 21, 2023

seems not sure if it worked for someone, but it's stuck for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer doesn't trigger signer window
4 participants