Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 BSX usd value #5304

Merged
merged 2 commits into from
Mar 20, 2023
Merged

🔧 BSX usd value #5304

merged 2 commits into from
Mar 20, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Mar 20, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • fix bug in the display of BSX USD value showing $NaN
  • Requires deployment <>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Before

image

After

image

@daiagi daiagi requested a review from a team as a code owner March 20, 2023 08:33
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team March 20, 2023 08:33
@netlify
Copy link

netlify bot commented Mar 20, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 5be4965
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/64181b46931933000802f2c6
😎 Deploy Preview https://deploy-preview-5304--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Mar 20, 2023

Code Climate has analyzed commit 5be4965 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🩹.
I learned something today 😅

@vikiival vikiival merged commit a92203e into kodadot:main Mar 20, 2023
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Mar 20, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 36.06 USD/KSM ~ 0.277 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x12d60f4259990b4a898164b2f60e8eeddf1aabc77425b06e2fa3c0401de9200d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants