Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase card number on landing #5295

Merged
merged 5 commits into from
Mar 19, 2023

Conversation

floyd-li
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.

just increase the card number on landing page, make it 6 card on width > 1280 and 4 on width > 1024.

also improve the card slide step on different width

@exezbcz mr.designer if there's any suggestion please tell me lol

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

@floyd-li floyd-li requested a review from a team as a code owner March 18, 2023 08:41
@floyd-li floyd-li requested review from preschian and vikiival and removed request for a team March 18, 2023 08:41
@kodabot
Copy link
Collaborator

kodabot commented Mar 18, 2023

SUCCESS @floyd-li PR for issue #5256 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 18, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit bb67cae
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6417559dafcb5200089a0e71
😎 Deploy Preview https://deploy-preview-5295--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@exezbcz
Copy link
Member

exezbcz commented Mar 18, 2023

bruh, is it new thing calling me like that? :D
Let's make it 5 card on width > 1280 and 4 on width > 1024.
and if it would be possible - add breakpoint for 1540 (where currently is for the top collections) and put 6 cards there
This way you wont get 6 small cards on 13" screens

  • plus for the xl screens, can you edit the featured articles part? Maybe like from 1540 - 4 cards instead of 3

Thanks!

@floyd-li
Copy link
Member Author

@exezbcz updated

@exezbcz
Copy link
Member

exezbcz commented Mar 19, 2023

@floyd-li yes, good!

@codeclimate
Copy link

codeclimate bot commented Mar 19, 2023

Code Climate has analyzed commit bb67cae and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

pay 20 usd

@vikiival vikiival merged commit e9cf512 into kodadot:main Mar 19, 2023
@yangwao
Copy link
Member

yangwao commented Mar 19, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 37.31 USD/KSM ~ 0.536 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0x9982ef70cac1c1a1052bcf0c8b37ec7dd0a687acfe7138914c4aba98dc54bb3f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 19, 2023
@floyd-li floyd-li deleted the feat/increase-card-number branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase number of cards on carousel landing page
5 participants