Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load rmrk2 image on gallery item #5279

Merged
merged 13 commits into from
Mar 21, 2023
Merged

feat: load rmrk2 image on gallery item #5279

merged 13 commits into from
Mar 21, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Mar 15, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
   
Screenshot 2023-03-15 at 23 25 15 Screenshot 2023-03-15 at 23 25 33

@netlify
Copy link

netlify bot commented Mar 15, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f6919b9
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6419aae53ea22c00075f43f5
😎 Deploy Preview https://deploy-preview-5279--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review March 15, 2023 15:31
@preschian preschian requested a review from a team as a code owner March 15, 2023 15:31
@preschian preschian requested review from vikiival and daiagi and removed request for a team March 15, 2023 15:31
@daiagi daiagi added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Mar 16, 2023
vikiival
vikiival requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to avoid naming anything RMRK

components/base/types.ts Outdated Show resolved Hide resolved
composables/useNft.ts Outdated Show resolved Hide resolved
@marcelosousa
Copy link
Contributor

/reviewpad summarize

@reviewpad
Copy link
Contributor

reviewpad bot commented Mar 17, 2023

This pull request includes multiple changes across different files. In the types.ts file, an import statement for RMRK2Resources from useNft.ts is added, as well as updates to the BaseTokenType interface to include a newly added property secondFile, and additions to the CarouselNFT interface to extend the RMRK2Resources interface. Another modified file is the scheme.ts file, which imports RMRK2Resources from the useNft module and adds it to the NFTMetadata and NFT interfaces, while also changing the attributes property of the Metadata interface to be optional. In addition, the queryPrefix value is dynamically determined based on the URL prefix value in the useGalleryItem.ts file. There are also a few changes in the CarouselMedia.vue file such as changes to the poster and src props and the use of the sanitizeIpfsUrl function. Finally, there are new GraphQL queries for retrieving a NFT entity and a collection entity by their IDs.

@marcelosousa marcelosousa mentioned this pull request Mar 17, 2023
Merged
@vikiival
Copy link
Member

@preschian can we please proceed? 🥺

@preschian
Copy link
Member Author

@preschian can we please proceed? 🥺

sure, will fix the review 🙏

@preschian preschian marked this pull request as draft March 21, 2023 01:49
@preschian preschian marked this pull request as ready for review March 21, 2023 02:20
@preschian preschian requested a review from vikiival March 21, 2023 02:20
@vikiival vikiival mentioned this pull request Mar 21, 2023
Open
@vikiival vikiival enabled auto-merge March 21, 2023 13:02
@codeclimate
Copy link

codeclimate bot commented Mar 21, 2023

Code Climate has analyzed commit f6919b9 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 6e418fe into main Mar 21, 2023
@vikiival vikiival deleted the feat/rmrk2-image-gallery-item branch March 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load image rmrk2 that doesn't have mediaUri
4 participants
@preschian @marcelosousa @vikiival @daiagi