Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5132 Gallery item detail description #5134

Merged
merged 5 commits into from
Mar 6, 2023
Merged

#5132 Gallery item detail description #5134

merged 5 commits into from
Mar 6, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Feb 28, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@prachi00 prachi00 requested a review from a team as a code owner February 28, 2023 05:16
@prachi00 prachi00 requested review from roiLeo and Jarsen136 and removed request for a team February 28, 2023 05:16
@netlify
Copy link

netlify bot commented Feb 28, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 2fec298
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6405d4e8051e2c000876369b
😎 Deploy Preview https://deploy-preview-5134--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Feb 28, 2023

SUCCESS @prachi00 PR for issue #5132 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

roiLeo
roiLeo suggested changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break mobile container

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 28, 2023
@prachi00 prachi00 changed the title THEMIS-5132 Gallery item detail description #5132 Gallery item detail description Feb 28, 2023
@prachi00 prachi00 requested a review from roiLeo March 1, 2023 03:52
roiLeo
roiLeo approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird fix but ok.

@roiLeo roiLeo added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Mar 1, 2023
@Jarsen136
Copy link
Contributor

I could still reproduce it on the smaller screen in your preview env
image

@yangwao yangwao added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 1, 2023
@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

Don't want to break something on production

@prachi00
Copy link
Member Author

prachi00 commented Mar 2, 2023

I could still reproduce it on the smaller screen in your preview env image

can you tell me the exact screen size? not happening for me

@Jarsen136
Copy link
Contributor

can you tell me the exact screen size? not happening for me

the screen with is shorter than 315px
image

@prachi00
Copy link
Member Author

prachi00 commented Mar 3, 2023

can you tell me the exact screen size? not happening for me

the screen with is shorter than 315px image

@Jarsen136 should we even support screens that are shorter than 315 px? I dont think any smartphone has that, right?
https://accessally.com/blog/mobile-responsive-screen-sizes/
according to this, iphone 5 has the smallest screen currently at 320px
I dont think we need to handle this, what do you think?

@Jarsen136
Copy link
Contributor

@Jarsen136 should we even support screens that are shorter than 315 px? I dont think any smartphone has that, right? https://accessally.com/blog/mobile-responsive-screen-sizes/ according to this, iphone 5 has the smallest screen currently at 320px I dont think we need to handle this, what do you think?

Alright, let it go.

@Jarsen136 Jarsen136 removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 3, 2023
@vikiival
Copy link
Member

vikiival commented Mar 6, 2023

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Mar 6, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 34.88 USD/KSM ~ 0.287 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xc0b09582e282d0a52e5411a4071173c442b101035acb4d45b21d7d3337dd9ebf

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 6, 2023
@vikiival vikiival enabled auto-merge March 6, 2023 11:56
@codeclimate
Copy link

codeclimate bot commented Mar 6, 2023

Code Climate has analyzed commit 2fec298 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival disabled auto-merge March 6, 2023 12:03
@vikiival vikiival merged commit e5a165a into main Mar 6, 2023
@vikiival vikiival deleted the feat-padding-issue branch March 6, 2023 12:03
@floyd-li floyd-li mentioned this pull request Mar 22, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gallery item detail description at 770px
6 participants
@prachi00 @kodabot @Jarsen136 @yangwao @vikiival @roiLeo