Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bring back accept cookies toast #4664

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix: bring back accept cookies toast #4664

merged 1 commit into from
Jan 11, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 11, 2023 14:58
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team January 11, 2023 14:58
@kodabot
Copy link
Collaborator

kodabot commented Jan 11, 2023

SUCCESS @Jarsen136 PR for issue #4660 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jan 11, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit bac7b5e
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63bece97e373870008601df1
😎 Deploy Preview https://deploy-preview-4664--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 11, 2023

Code Climate has analyzed commit bac7b5e and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

By the way, I wonder if we should redesign the cookies toast component.

image

@vikiival
Copy link
Member

By the way, I wonder if we should redesign the cookies toast component.

cc @exezbcz

@vikiival
Copy link
Member

pay 20 usd

@vikiival vikiival merged commit f0b1a63 into kodadot:main Jan 11, 2023
@yangwao
Copy link
Member

yangwao commented Jan 11, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 26.49 USD/KSM ~ 0.755 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xc38483cfaa9c5ad546f06c3f424b1f2be44a4584132c021068183c92fb2a3715

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accept cookies toast
4 participants
@Jarsen136 @kodabot @vikiival @yangwao