Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing user address in profile hover card #4539

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

@kodabot
Copy link
Collaborator

kodabot commented Dec 21, 2022

SUCCESS @Jarsen136 PR for issue #4537 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Dec 21, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 2d08c64
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63a302ceb90f3f0009452c93
😎 Deploy Preview https://deploy-preview-4539--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136 Jarsen136 marked this pull request as ready for review December 21, 2022 12:57
@Jarsen136 Jarsen136 requested a review from a team as a code owner December 21, 2022 12:57
@Jarsen136 Jarsen136 requested review from prachi00 and removed request for a team December 21, 2022 12:57
@codeclimate
Copy link

codeclimate bot commented Dec 21, 2022

Code Climate has analyzed commit 2d08c64 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 21, 2022
@yangwao
Copy link
Member

yangwao commented Dec 21, 2022

pay 50 usd

speedy express

@yangwao
Copy link
Member

yangwao commented Dec 21, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 24.44 USD/KSM ~ 2.046 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x8d3b86b926e94e91d7b26ade4182ab8bf065f9f45122bb567088b3feb3ab8206

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 21, 2022
@yangwao yangwao self-requested a review December 21, 2022 17:27
@yangwao yangwao merged commit 1dd74f7 into kodadot:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing user address in profile hover card
4 participants