Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new articles and mobile experience goes out 💖 #4534

Merged
merged 119 commits into from
Dec 20, 2022
Merged

new articles and mobile experience goes out 💖 #4534

merged 119 commits into from
Dec 20, 2022

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Dec 20, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

daiagi and others added 24 commits December 17, 2022 11:58
# Conflicts:
#	components/gallery/GalleryItem.vue
fix: Cut text at some length on landing page
fix: content dissapears after few seconds in walletModal in mobile devices
fix : scroll bar when timeframe dropdown is open in price chart
🐛 navbar non-mobile smaller screen
[skip ci] updated code diagram
@yangwao yangwao requested a review from a team as a code owner December 20, 2022 16:27
@yangwao yangwao requested review from roiLeo and removed request for a team December 20, 2022 16:27
@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 759333e
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63a1e264af201700099c4c98
😎 Deploy Preview https://deploy-preview-4534--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao merged commit 5b57683 into hyper-jpeg Dec 20, 2022
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants