-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4125 mobile navbar #4483
#4125 mobile navbar #4483
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@yangwao @preschian worked on top of the previous PR that was raised |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to fix deepscan and deepsource issues. and follow vue best practices for props https://v2.vuejs.org/v2/style-guide/?redirect=true#Prop-definitions-essential
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exezbcz how exactly the search on mobile should look? I cant find the designs for that |
okay, so we are going to keep the version that is currently on beta.kodadot.xyz with few changes.
Is this okay? |
Code Climate has analyzed commit 9d4321a and detected 0 issues on this pull request. View more on Code Climate. |
This can be fixed in the follow-up issue as it's for the non-mobile devices but on 600px width I guess we will make follow-up issue on this one Address select dialogue |
pay 80 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Payout
Community participation
Screenshot 📸