Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[#2447]: optimize replaceUrl of SearchBar #2488

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

shixin-guo
Copy link
Contributor

@shixin-guo shixin-guo commented Mar 2, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Mar 2, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 97a285e

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/621f7990674e82000787bc98

😎 Browse the preview: https://deploy-preview-2488--koda-nuxt.netlify.app

@yangwao yangwao requested a review from roiLeo March 2, 2022 14:34
@yangwao
Copy link
Member

yangwao commented Mar 2, 2022

yup works!

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Mar 2, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 138.39 USD/KSM ~ 0.723 $KSM
🧗 JHrNQ8vYNYPLCB3VBG1pqQWVHyZb8XDKc2R9mwcXYvtjPwN
🔗 0xe07fc97e53b52f88e5944e19d6e0aad19108f69747b378e1d31a4c7fc8ada238

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 2, 2022
@yangwao yangwao merged commit 688bc15 into kodadot:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh some page page then redirect to other page
2 participants