fix: Error createCanvas function not found #11170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew instance. - creates a new regex instance each time to fix lastIndex issues with the global flag, ensuring consistent matching in canvas validation.
hassnian
requested review from
vikiival and
Jarsen136
and removed request for
a team
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Jarsen136
approved these changes
Oct 29, 2024
vikiival
approved these changes
Oct 29, 2024
This was referenced Nov 28, 2024
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Context
Issue
canvasRegexuses the global flag (g), which causes the regex'slastIndexto be updated after each match. This results in returningnullon alternating calls, leading to showError createCanvas function not foundeither this solution or remove the global flag
gScreenshot 📸