Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Profile weird link formating from warpcast #10973

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

hassnian
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Screenshot 📸

  • My fix has changed something on UI;

@hassnian hassnian requested a review from a team as a code owner September 13, 2024 09:14
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 287b199
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66e40501ffca3a0008c2d5d0
😎 Deploy Preview https://deploy-preview-10973--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Use concise character class syntax '\w' instead of '[a-zA-Z0-9_]'.
Copy link

@Jarsen136
Copy link
Contributor

Jarsen136 commented Sep 13, 2024

nvm, the user should sync his profile again to make it work, right?
https://deploy-preview-10973--koda-canary.netlify.app/ahp/u/5EZdSLPuEwSafwxABL7RYU1AXqjma5qRo3qE2kk61wKLjckx

image

@hassnian
Copy link
Contributor Author

hassnian commented Sep 14, 2024

nvm, the user should sync his profile again to make it work, right? https://deploy-preview-10973--koda-canary.netlify.app/ahp/u/5EZdSLPuEwSafwxABL7RYU1AXqjma5qRo3qE2kk61wKLjckx

yes, it was decided that it should only get bio links (channel and username) when the user imports from warpcast

CleanShot 2024-09-14 at 09 54 29@2x

@Jarsen136 Jarsen136 added this pull request to the merge queue Sep 15, 2024
Merged via the queue into kodadot:main with commit 7ae78c6 Sep 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile: Weird link formating from warpcast
3 participants