Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hover card changes #10476

Merged
merged 10 commits into from
Jun 19, 2024
Merged

feat: Hover card changes #10476

merged 10 commits into from
Jun 19, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jun 17, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-06-17 at 16 00 18

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1903c25
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66710849681864000985c881
😎 Deploy Preview https://deploy-preview-10476--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian hassnian marked this pull request as ready for review June 17, 2024 11:01
@hassnian hassnian requested a review from a team as a code owner June 17, 2024 11:01
@hassnian hassnian requested review from vikiival and daiagi and removed request for a team June 17, 2024 11:01
@prury
Copy link
Member

prury commented Jun 17, 2024

i think profile image should be clickable and lead to profile instead of clicking on address to go to profile, wdyt @exezbcz ?

@prury prury requested review from preschian and removed request for daiagi June 17, 2024 12:55
@exezbcz
Copy link
Member

exezbcz commented Jun 17, 2024

maybe i wrote it wrong, this should be clickable and redirect to a profile
image

@exezbcz
Copy link
Member

exezbcz commented Jun 17, 2024

@prury yeah we can add redirect there as well

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 17, 2024
Copy link

codeclimate bot commented Jun 18, 2024

Code Climate has analyzed commit 1903c25 and detected 0 issues on this pull request.

View more on Code Climate.

@hassnian
Copy link
Contributor Author

maybe i wrote it wrong, this should be clickable and redirect to a profile

i think profile image should be clickable and lead to profile instead of clicking on address to go to profile

done

CleanShot 2024-06-18 at 09 12 47

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 18, 2024
@vikiival vikiival requested a review from Jarsen136 June 18, 2024 17:36
@prury prury added this pull request to the merge queue Jun 19, 2024
Merged via the queue into kodadot:main with commit c1d2aef Jun 19, 2024
19 checks passed
@prury prury deleted the issue-10457 branch June 19, 2024 11:11
This was referenced Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover card changes
5 participants