Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParaSpell to v5.5.0 #10438

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Update ParaSpell to v5.5.0 #10438

merged 4 commits into from
Jun 11, 2024

Conversation

dudo50
Copy link
Contributor

@dudo50 dudo50 commented Jun 8, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

(please remove design and QA checks below if not needed)

Context

PR introduces hotfix to breaking change introduced by Parity in runtime 1.2.5. Should work out of the box now. We also introduced Polkadot<>Kusama bridge in this version. If you find useful usecase for it within Kodadot let us know in Telegram. We also had to update peer dependencies (PJS packages, that did not have breaking change implemented yet).

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • Tested on main net

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

@dudo50 dudo50 requested a review from a team as a code owner June 8, 2024 18:57
@dudo50 dudo50 requested review from Jarsen136 and hassnian and removed request for a team June 8, 2024 18:57
Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 632985c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66681e390f036f0008533774
😎 Deploy Preview https://deploy-preview-10438--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

socket-security bot commented Jun 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@kodadot1/sub-api@0.3.2-rc.0 None 0 16.3 kB vikiival
npm/chart.js@4.4.2 None 0 4.93 MB chartjs-ci
npm/consola@3.2.3 environment 0 228 kB pi0
npm/cross-env@7.0.3 environment 0 29.1 kB kentcdodds
npm/date-fns@2.30.0 None 0 6.69 MB kossnocorp
npm/eslint@8.57.0 environment, filesystem 0 3.04 MB eslintbot
npm/glob@8.1.0 filesystem 0 56.2 kB isaacs
npm/graphql@16.8.1 None 0 1.34 MB i1g
npm/husky@7.0.4 filesystem, shell 0 6.06 kB typicode
npm/jsdom@19.0.0 eval, filesystem, network, shell, unsafe 0 2.83 MB domenic
npm/keen-slider@6.8.6 None 0 170 kB rcbyr
npm/lint-staged@12.5.0 None 0 106 kB okonet
npm/markdown-it@13.0.2 None 0 563 kB vitaly
npm/nuxt-speedkit@3.0.0-next.27 environment, filesystem 0 165 kB gp-dev
npm/ofetch@1.3.4 environment, network +1 63.4 kB pi0
npm/partysocket@0.0.25 network 0 116 kB threepointone
npm/postcss@8.4.38 environment, filesystem +1 219 kB ai
npm/prettier@3.2.5 environment, filesystem, unsafe 0 8.39 MB prettier-bot
npm/prism-themes@1.9.0 None 0 231 kB rundevelopment
npm/prismjs@1.29.0 None 0 2.05 MB rundevelopment
npm/sass@1.77.1 filesystem, unsafe 0 5.22 MB sassbot
npm/slugify@1.6.6 None 0 20.9 kB simov
npm/tailwindcss@3.4.3 environment, filesystem +1 5.52 MB adamwathan
npm/unzipit@1.4.3 network 0 168 kB greggman
npm/wavesurfer.js@7.7.14 network 0 566 kB katspaugh
npm/workbox-window@6.6.1 environment 0 557 kB tropicadri

View full report↗︎

@vikiival
Copy link
Member

vikiival commented Jun 8, 2024

Thank you @dudo50!

I need to update internal packages too 😅

@prury
Copy link
Member

prury commented Jun 10, 2024

its the fee now being subtracted from the teleported amount or was it always the case?

@dudo50
Copy link
Contributor Author

dudo50 commented Jun 10, 2024

@prury Could you explain a little more in detail what you meant? I don't understand what fee you mean. Is this question regarded to ParaSpell XCM SDK or Kodadot? Thanks!

With kind regards,
Team ParaSpell

@prury
Copy link
Member

prury commented Jun 10, 2024

@prury Could you explain a little more in detail what you meant? I don't understand what fee you mean. Is this question regarded to ParaSpell XCM SDK or Kodadot? Thanks!

With kind regards, Team ParaSpell

nevermind dudo, i made some tests and found what i was looking for

@prury
Copy link
Member

prury commented Jun 10, 2024

polkadot <=> kusama bridge? that's nice

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 10, 2024
@vikiival
Copy link
Member

@dudo50 please update @kodadot1/sub-api to 0.3.2-rc.0 I cannot push to your repo

@dudo50
Copy link
Contributor Author

dudo50 commented Jun 11, 2024

@vikiival , done

Copy link

codeclimate bot commented Jun 11, 2024

Code Climate has analyzed commit 632985c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vikiival vikiival merged commit e2c15f2 into kodadot:main Jun 11, 2024
19 checks passed
@vikiival vikiival mentioned this pull request Jun 12, 2024
This was referenced Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants