Merge pull request #11340 from roiLeo/fix/massmint/missingNamesNumbers

🔧 massmint missing names & numbers
kodadot · Jan 7, 2025 · 1073e8a · 1073e8a
2 parents a1a9749 + bb949a4
commit 1073e8a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/components/massmint/Massmint.vue b/components/massmint/Massmint.vue
@@ -75,7 +75,7 @@
     />
     <MissingInfoModal
       v-model="missingInfoModalOpen"
-      :num-missing-names="numberOfMissingNames"
+      :missing-names="missingNames"
       :num-missing-descriptions="numberOfMissingDescriptions"
       :num-missing-prices="numberOfMissingPrices"
       @close="missingInfoModalOpen = false"
@@ -156,12 +156,10 @@ const mintStatus = ref('')
 const neededAmount = computed(() => ((itemDeposit.value + metadataDeposit.value) * Object.keys(NFTS.value).length) + transactionFee.value)
 const hasEnoughBalance = computed(() => (transferableCurrentChainBalance.value ?? 0) >= neededAmount.value)
 
-const numberOfMissingNames = computed(
-  () => Object.values(NFTS.value).filter(nft => !nft.name).length,
-)
+const missingNames = computed(() => Object.values(NFTS.value).filter(nft => !nft.name))
 
 const numOfValidNFTs = computed(
-  () => Object.values(NFTS.value).length - numberOfMissingNames.value,
+  () => Object.values(NFTS.value).length - missingNames.value.length,
 )
 const numberOfMissingDescriptions = computed(
   () => Object.values(NFTS.value).filter(nft => !nft.description).length,
@@ -185,7 +183,7 @@ const closeDeleteModal = () => {
 }
 
 const openReviewModal = () => {
-  if (numberOfMissingNames.value > 0) {
+  if (missingNames.value && missingNames.value.length) {
     missingInfoModalOpen.value = true
     return
   }

diff --git a/components/massmint/modals/MissingInfoModal.vue b/components/massmint/modals/MissingInfoModal.vue
@@ -14,7 +14,7 @@
           <div>{{ $t('massmint.required') }}</div>
 
           <div class="pl-3">
-            • {{ $t('massmint.incompleteNfts', { count: numMissingNames }) }}
+            • {{ $t('massmint.incompleteNfts', { count: missingNames.length }) }} ({{ missingNames.map(nft => `#${nft.id}`).join(', ') }})
           </div>
         </div>
         <div
@@ -35,7 +35,7 @@
             }}
           </div>
           <div
-            v-if="numMissingNames"
+            v-if="numMissingPrices"
             class="pl-3"
           >
             •
@@ -65,10 +65,11 @@
 
 <script setup lang="ts">
 import { NeoButton, NeoModal } from '@kodadot1/brick'
+import type { NFT } from '../types'
 
 const props = defineProps<{
   modelValue: boolean
-  numMissingNames: number
+  missingNames: NFT[]
   numMissingDescriptions: number
   numMissingPrices: number
 }>()