[klogs] Fix Logs Page Layout #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user selected a lot of fields in the logs table, the fields sidebar shrunk until it wasn't visible anymore. This is now fixed by adding the "overflowX" property to the logs bucket chart and table, so that the fields sidebar has always a width of 250px.
Codecov Report
@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 70.34% 70.36% +0.01%
==========================================
Files 370 370
Lines 59051 59060 +9
Branches 2647 2647
==========================================
+ Hits 41542 41560 +18
+ Misses 17248 17243 -5
+ Partials 261 257 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user selected a lot of fields in the logs table, the fields sidebar shrunk until it wasn't visible anymore. This is now fixed by adding the "overflowX" property to the logs bucket chart and table, so that the fields sidebar has always a width of 250px.