fix(trashBin): give each trash type its own restart budget DEV-2618 - #7514
Open
rajpatel24 wants to merge 2 commits into
Open
fix(trashBin): give each trash type its own restart budget DEV-2618#7514rajpatel24 wants to merge 2 commits into
rajpatel24 wants to merge 2 commits into
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📣 Summary
Splits
MAX_RESTARTED_TASKSinto three per-type settings for trash bin deletions, and stopstask_restarterfrom swallowing its own soft time limit.📖 Description
Implements the findings from #7422 and supersedes it.
The investigation showed that limiting how many deletions
task_restarterenqueues does not limit DB pressure: concurrency is set by the size of the worker pool, not by how many messages are published. Two things from #7422 are worth keeping on their own merits, and this PR is just those two.All default to 100, so behaviour is unchanged. They are separate because the three deletions do not cost the same.
SoftTimeLimitExceeded. In the enqueue block it was caught by the generic except Exception and logged as Could not restart #, which is wrong on both counts: nothing is wrong with the object, and the restarter had already claimed it, so it sat untouched until the next stuck threshold ~76 minutes later. It now restoresdate_modifiedand re-raises.