Skip to content

Conversation

@rgraber
Copy link
Contributor

@rgraber rgraber commented Dec 16, 2025

🗒️ Checklist

  1. run linter locally
  2. update developer docs (API, README, inline, etc.), if any
  3. for user-facing doc changes create a Zulip thread at #Support Docs Updates, if any
  4. draft PR with a title <type>(<scope>)<!>: <title> DEV-1234
  5. assign yourself, tag PR: at least Front end and/or Back end or workflow
  6. fill in the template below and delete template comments
  7. review thyself: read the diff and repro the preview as written
  8. open PR & confirm that CI passes & request reviewers, if needed
  9. delete this section before merging

📣 Summary

Updates the /data endpoint to return the answers to QA questions in a different format.

💭 Notes

Updates the data endpoint to return a dict of question_id: answer instead of a list that we then have to search by uuid. Keeps it consistent with other subsequence actions and makes it a little quicker to process. Requires a new version of formpack.
We don't include supplement stuff in the docs for the /data endpoint so there's no OpenAPI docs to update.

👀 Preview steps

Regression only

  1. ℹ️ have an account and a project with an audio question and at least one submission
  2. Add every type of QA question. You can either follow the directions here: (internal link) to do this with curl, or switch back to main and do it via the UI, then switch back to the PR branch and hit /api/v2/assets/<asset_uid>/advanced-features to migrate them.
  3. Navigate to the data table
  4. 🟢 All QA answers should be present
  5. Export the data
  6. 🟢 All QA answers should be in the export

@rgraber rgraber changed the base branch from main to refactor-subsequences-2025 December 16, 2025 19:44
@rgraber rgraber changed the title Beccagraber/update data interface refactor(subsequences): refactor data table for consistency Dec 18, 2025
@rgraber rgraber marked this pull request as ready for review December 18, 2025 18:13
@rgraber rgraber self-assigned this Dec 18, 2025
@rgraber rgraber added API Changes related to API endpoints Back end labels Dec 18, 2025
@rajpatel24 rajpatel24 self-requested a review December 19, 2025 11:46
Copy link
Contributor

@rajpatel24 rajpatel24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please update to the latest commit from main once you've merged the Formpack PR :)

@rgraber rgraber merged commit 8886c8c into refactor-subsequences-2025 Dec 19, 2025
13 checks passed
@rgraber rgraber deleted the beccagraber/update-data-interface branch December 19, 2025 15:30
rgraber added a commit that referenced this pull request Dec 24, 2025
Updates the /data endpoint to return the answers to QA questions in a
different format.

Updates the data endpoint to return a dict of question_id: answer
instead of a list that we then have to search by uuid. Keeps it
consistent with other subsequence actions and makes it a little quicker
to process. Requires a new version of formpack.
We don't include supplement stuff in the docs for the /data endpoint so
there's no OpenAPI docs to update.

Regression only

1. ℹ️ have an account and a project with an audio question and at least
one submission
2. Add every type of QA question. You can either follow the directions
here: (internal
[link](https://linear.app/kobotoolbox/issue/DEV-1301/update-formpack-to-accept-new-shape-of-data))
to do this with curl, or switch back to `main` and do it via the UI,
then switch back to the PR branch and hit
`/api/v2/assets/<asset_uid>/advanced-features` to migrate them.
3. Navigate to the data table
4. 🟢 All QA answers should be present
5. Export the data
7. 🟢 All QA answers should be in the export
rgraber added a commit that referenced this pull request Dec 30, 2025
…ecently accepted DEV-1497 (#6575)

### 📣 Summary
Display the most recent QA answers in the data table and exports rather
than the most recently accepted.

### 💭 Notes
In preparation for Automatic QA. 
Internal link:
https://linear.app/kobotoolbox/issue/DEV-1497/refactor-submissionsupplementretrieve-data-to-allow-unaccepted-data#comment-9521edef


### 👀 Preview steps
Regression test only, until we have automatic qual analysis this
shouldn't actually change what shows up in the data table because manual
answers are automatically accepted.

See #6559 for steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Changes related to API endpoints Back end

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants