Feature: Library Locking UI #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-feature-combined
[Library locking] Add locking to translation modal
duvld
approved these changes
May 28, 2021
Conflicts: jsapp/scss/_colors.scss jsapp/scss/components/_kobo.modal.scss jsapp/scss/stylesheets/partials/form_builder/_group.scss
jnm
requested changes
Jun 14, 2021
There was a problem hiding this comment.
@joshuaberetta, just a few small things. i opted to add my comments here instead of trying to reopen #3082.
maybe we can wait until kobotoolbox/formpack#238 is merged, then add a commit to this branch pointing at the latest formpack, and then merge this PR.
jdugh
pushed a commit
to geohyd/kpi
that referenced
this pull request
Nov 21, 2022
…king-ui Feature: Library Locking UI
jdugh
pushed a commit
to geohyd/kpi
that referenced
this pull request
Nov 13, 2023
…king-ui Feature: Library Locking UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes the huge #3120 PR and we should wait for it to be merged before tackling this.
Related issues
Fixes #3032
Fixes #2994