Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two new pages added, two nav pages updated, one exiting page updated, one image added. #232

Conversation

Hikkigaya
Copy link
Collaborator

@Hikkigaya Hikkigaya commented Jun 11, 2024

Two new pages were added, two nav pages were updated, one existing page was updated, and one image was added.
New pages:

Summary

Two new pages were added, two nav pages were updated, one exiting page was updated, and one image was added.

Related PRs, issues, or features (optional)

  • N/A

Metadata

  • Adds new file(s)
  • Edits existing file(s)
  • Removes file(s)

PR contributor checklist

@Hikkigaya Hikkigaya linked an issue Jun 11, 2024 that may be closed by this pull request
@tungmhoang
Copy link
Collaborator

@erincbailey you can now preview the changes (see links in PR description).

@tungmhoang tungmhoang marked this pull request as ready for review June 14, 2024 11:44
Copy link
Contributor

@erincbailey erincbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few changes and a few questions. Thank you!

@tungmhoang
Copy link
Collaborator

@erincbailey addressed all but 1 comments (need your input). Preview links updated with latest changes.

@erincbailey
Copy link
Contributor

@tungmhoang I reviewed all the comments. I added two comments. Happy for you to publish after those addressed. I don't need to review again.

Copy link
Contributor

@erincbailey erincbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all the changes. Have two comments. Happy for you to publish once those addressed.

@tungmhoang
Copy link
Collaborator

@erincbailey Only see 1 comments. If you are happy with the changes please approve.

Copy link
Contributor

@erincbailey erincbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change and good to publish.

@tungmhoang tungmhoang merged commit ec05e70 into main Jun 20, 2024
1 check passed
@tungmhoang tungmhoang deleted the 230-add-ios-image-injection-sdk-and-image-injection-automation-guide branch June 20, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add iOS image injection SDK and image injection automation guide
3 participants