-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two new pages added, two nav pages updated, one exiting page updated, one image added. #232
Two new pages added, two nav pages updated, one exiting page updated, one image added. #232
Conversation
… one image added.
… automation session
@erincbailey you can now preview the changes (see links in PR description). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few changes and a few questions. Thank you!
docs/modules/apps/pages/image-injection-sdk/add-the-sdk-to-your-ios-app.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/create-image-injection-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/create-image-injection-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/create-image-injection-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/create-image-injection-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/create-image-injection-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/create-image-injection-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/create-image-injection-script.adoc
Outdated
Show resolved
Hide resolved
@erincbailey addressed all but 1 comments (need your input). Preview links updated with latest changes. |
@tungmhoang I reviewed all the comments. I added two comments. Happy for you to publish after those addressed. I don't need to review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all the changes. Have two comments. Happy for you to publish once those addressed.
@erincbailey Only see 1 comments. If you are happy with the changes please approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change and good to publish.
Two new pages were added, two nav pages were updated, one existing page was updated, and one image was added.
New pages:
Edited pages:
Summary
Two new pages were added, two nav pages were updated, one exiting page was updated, and one image was added.
Related PRs, issues, or features (optional)
Metadata
PR contributor checklist
My PR follows the Kobiton Docs contributor guidelines, meaning:
nav.adoc
file.en-us
) from my URLs.