-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhook Integration Section Added #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hikkigaya I have left several comments. Otherwise great work.
docs/modules/integrations/pages/webhooks/create-and-manage-webhooks.adoc
Outdated
Show resolved
Hide resolved
docs/modules/integrations/pages/webhooks/create-and-manage-webhooks.adoc
Outdated
Show resolved
Hide resolved
docs/modules/integrations/pages/webhooks/create-and-manage-webhooks.adoc
Outdated
Show resolved
Hide resolved
…tables in existing pages
…ystem from chaniging the .css file from LS to CRLF
Nope, adding the attribute file did not work. I will just add the two CSS file in .gitignore as well. You were right, the changes were due to working on a Windows machine in which git converts the LF line endings to CRLF. |
@Hikkigaya One more thing, the screenshots in this page is taken before our latest design change. Could you use your Kobiton account, follow the webhook guides and take the update screenshots for all images in this doc, making sure that no image is more than 100KB in size? |
@tungmhoang Sure, I will get it done. |
@tungmhoang The images have been updated. |
@erincbailey this update is available at http://10.2.7.208/integrations/webhooks/create-and-manage-webhooks. You can start your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Have a few comments to change.
Also - I don't love only having one page in a section. Should we just open this content when you click Webhooks or do you think we should break it into at least two pages?
docs/modules/integrations/pages/webhooks/create-and-manage-webhooks.adoc
Outdated
Show resolved
Hide resolved
docs/modules/integrations/pages/webhooks/create-and-manage-webhooks.adoc
Outdated
Show resolved
Hide resolved
docs/modules/integrations/pages/webhooks/create-and-manage-webhooks.adoc
Outdated
Show resolved
Hide resolved
docs/modules/integrations/pages/webhooks/create-and-manage-webhooks.adoc
Outdated
Show resolved
Hide resolved
docs/modules/integrations/pages/webhooks/create-and-manage-webhooks.adoc
Outdated
Show resolved
Hide resolved
@Hikkigaya I will push a commit to address this (show the content in Create and manage webhooks right away when opening Webhooks) |
@erincbailey please review one more time using this link: http://10.2.7.208/integrations/create-and-manage-webhooks |
Summary
Added the entire Webhook Integration section in Integrations
Related PRs, issues, or features (optional)
Metadata
PR contributor checklist
My PR follows the Kobiton Docs contributor guidelines, meaning:
nav.adoc
file.en-us
) from my URLs.