Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook Integration Section Added #204

Merged
merged 13 commits into from
May 14, 2024
Merged

Conversation

Hikkigaya
Copy link
Collaborator

Summary

Added the entire Webhook Integration section in Integrations

Related PRs, issues, or features (optional)

  • Added content, images, tables, and notes.
  • Reduced the size of the images.
  • Adding internal linking to the main integration page as well.

Metadata

  • [x ] Adds new file(s)
  • [x ] Edits existing file(s)
  • Removes file(s)

PR contributor checklist

@Hikkigaya Hikkigaya linked an issue Apr 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@tungmhoang tungmhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hikkigaya I have left several comments. Otherwise great work.

.vs/VSWorkspaceState.json Outdated Show resolved Hide resolved
.vs/docs/v16/.suo Outdated Show resolved Hide resolved
.vs/slnx.sqlite Outdated Show resolved Hide resolved
docs/modules/integrations/pages/webhooks/index.adoc Outdated Show resolved Hide resolved
ui-bundle-docs/css/site.css Outdated Show resolved Hide resolved
ui-bundle-widget/css/site.css Outdated Show resolved Hide resolved
@tungmhoang tungmhoang marked this pull request as ready for review April 22, 2024 07:49
@Hikkigaya
Copy link
Collaborator Author

Nope, adding the attribute file did not work.

I will just add the two CSS file in .gitignore as well. You were right, the changes were due to working on a Windows machine in which git converts the LF line endings to CRLF.

@tungmhoang
Copy link
Collaborator

@Hikkigaya One more thing, the screenshots in this page is taken before our latest design change. Could you use your Kobiton account, follow the webhook guides and take the update screenshots for all images in this doc, making sure that no image is more than 100KB in size?
You just need to take the screenshot, no need to do the highlighting.

@Hikkigaya
Copy link
Collaborator Author

@tungmhoang Sure, I will get it done.

@Hikkigaya
Copy link
Collaborator Author

@tungmhoang The images have been updated.

.vs/VSWorkspaceState.json Outdated Show resolved Hide resolved
@tungmhoang
Copy link
Collaborator

@erincbailey this update is available at http://10.2.7.208/integrations/webhooks/create-and-manage-webhooks. You can start your review.

Copy link
Contributor

@erincbailey erincbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have a few comments to change.
Also - I don't love only having one page in a section. Should we just open this content when you click Webhooks or do you think we should break it into at least two pages?

@tungmhoang
Copy link
Collaborator

tungmhoang commented May 13, 2024

Looks good. Have a few comments to change. Also - I don't love only having one page in a section. Should we just open this content when you click Webhooks or do you think we should break it into at least two pages?

@Hikkigaya I will push a commit to address this (show the content in Create and manage webhooks right away when opening Webhooks)

@tungmhoang
Copy link
Collaborator

@erincbailey please review one more time using this link: http://10.2.7.208/integrations/create-and-manage-webhooks

@tungmhoang tungmhoang merged commit 57d85a2 into main May 14, 2024
1 check passed
@tungmhoang tungmhoang deleted the webhook-user-guide-migration branch May 14, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate the webhook user guide to new docs site
3 participants