Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additional entry inejcted to params #124

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Fix additional entry inejcted to params #124

merged 2 commits into from
Jul 20, 2021

Conversation

3imed-jaberi
Copy link
Member

fix #113

@dominicegginton
Copy link
Contributor

Can you write a unit test for this? 🧪

@3imed-jaberi 3imed-jaberi force-pushed the fix-additional-injected-params branch from f2b95e9 to 51b51c3 Compare July 20, 2021 20:19
3imed-jaberi
3imed-jaberi commented Jul 20, 2021
View reviewed changes
Copy link
Member Author

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and ready to merge

@niftylettuce
Copy link
Contributor

@3imed-jaberi minor version bump correct?

@3imed-jaberi
Copy link
Member Author

@3imed-jaberi minor version bump correct?

@niftylettuce, yes

@niftylettuce niftylettuce merged commit e9fa04b into koajs:master Jul 20, 2021
@niftylettuce
Copy link
Contributor

v10.1.0 released to npm 🎉 thank you @3imed-jaberi 🙇

https://github.com/koajs/router/releases/tag/v10.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router with prefix and middleware causes additional entry to get injected into ctx.params
3 participants
@3imed-jaberi @dominicegginton @niftylettuce