Core breaking issues with v9.x

[niftylettuce]

I'm not sure what's up here @Sinewyk @zacanger but I upgraded a project to v9.x and it broke authentication (Google auth passport).

Just filing this for now until I can figure it out.

[niftylettuce]

I deprecated v9.0.0 as I found core issues with it in my app

[Sinewyk]

Thoughts:

• It is a breaking change. Anyone using ^ (which is the default in all package managers afaik) should not have any issues UNLESS they specifically ask for a major upgrade (cf, read their accompanying package manager documentation). No need to lock things down (or deprecate), it's already the case.
• I'm interested in more information. All tests are green, and I actually don't see @koa/router being used in your automatically linked package other than in a test.

[zacanger]

Do you have a code sample? I just tried a super minimal test with koa-passport and the local strategy, and didn't have any problems.

[niftylettuce]

Yes, auth is broken on https://github.com/ladjs/lad.sh for Google Sign In. Not 100% sure why. I have unpublished v9.0.0 completely from npm with their help as well until this is further resolved.

…

On Mon, Apr 20, 2020 at 10:23 AM Zac Anger ***@***.***> wrote: Do you have a code sample? I just tried a super minimal test with koa-passport and the local strategy, and didn't have any problems. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#79 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD7XBO3QIO72DDPHEHMYT3RNRSHPANCNFSM4MMDRP2A> .

[lagden]

:(
I'm using v9.0.0!

[zacanger]

Unpublishing was probably a risky choice, that could break builds. I just had to run through six microservices and downgrade real quick.

[niftylettuce]

I only had published v9.0.0 to @koa/router (I did not mirror it to koa-router). If you want to keep using v9.0.0 you can install via:

npm install https://github.com/koajs/router#v9.0.0

or with yarn:

yarn add https://github.com/koajs/router#v9.0.0

[niftylettuce]

Or we can try to figure out what the underling issue is here - I believe it to be something with /foo/:param/bar personally.

[Sinewyk]

Major changes that could trip people up with the underlying path-to-regexp change:

• encode/decode stuff, if you used to just pass shit in the url, now you have to specify encode/decode when generating links <= I fixed the tests to use encode/decode, but no note in the readme.
• No more wildcard *, use the other syntax <= we had no test for this, but we added a note in the readme.
• They removed automatic /stuff/ ending slash removal, so there's a special behavior when prefixing and trying to add a route on '/' in koa-router if we did not specify strict. <= there's a test for this one.

[rynti]

I don't understand why the version was unpublished.
Version 9 introduced breaking changes, which means that users of the library potentially have to implement changes to keep their code working with the new version - which is what I had to do. But this should not be a surprise as the usage of semantic versioning (pushing a new major version) makes this apparent.
Nonetheless, thanks for providing the alternative route with installing the release via the GitHub URL which serves as a quick fix in my case.

[zacanger]

@niftylettuce could the trailing slash thing be the issue, if you have any routes that end in a slash? Here's a test I just did with v9:

const Koa = require('koa')
const Router = require('@koa/router')

const app = new Koa()
const router = new Router()

// GET foo/whatever/baz -> whatever
// GET foo/whatever/baz/ -> whatever
router.get('/foo/:bar/baz', (ctx) => {
  ctx.body = ctx.params.bar
})

// GET foo/whatever/quux/ -> whatever
// GET foo/whatever/quux (no slash) -> 404
router.get('/foo/:bar/quux/', (ctx) => {
  ctx.body = ctx.params.bar
})

app.use(router.routes())
app.listen(9999)

Which differs from v8, in v8 none of the requests resulted in a 404.

[ohardy]

Hi,

Really, you can't unpublish a package published more than 10 days ago !! Everything are stuck on our side because of that.

Can you publish again this version and handle fixes in a 9.0.1 plz ?

Thanks

[JacobMGEvans]

@niftylettuce could the trailing slash thing be the issue, if you have any routes that end in a slash? Here's a test I just did with v9:

const Koa = require('koa')
const Router = require('@koa/router')

const app = new Koa()
const router = new Router()

// GET foo/whatever/baz -> whatever
// GET foo/whatever/baz/ -> whatever
router.get('/foo/:bar/baz', (ctx) => {
  ctx.body = ctx.params.bar
})

// GET foo/whatever/quux/ -> whatever
// GET foo/whatever/quux (no slash) -> 404
router.get('/foo/:bar/quux/', (ctx) => {
  ctx.body = ctx.params.bar
})

app.use(router.routes())
app.listen(9999)

Which differs from v8, in v8 none of the requests resulted in a 404.

It would be a great test case to add too and include the Tests in the Travis build, which might catch future issues.