Add support for flushing headers#675
Merged
Merged
Conversation
Contributor
Author
|
Branch coverage dropped a branch from 218 to 217, but statement coverage remained the same. However, codecov didn't seem to process this PR, so I don't know which branch it is. |
Member
|
ah crap... because i need to add codecov to v2.x as well. damnit |
Contributor
Author
|
I thought that might be the case. Also, coveralls still seems to be running, I'm assuming we want to remove that? |
| try { | ||
| ctx.length = 10; | ||
| } catch (err) { | ||
| ctx.body += 'ctx.length fail'; |
Member
There was a problem hiding this comment.
interesting way to make sure things are thrown... haha
jonathanong
added a commit
that referenced
this pull request
Mar 12, 2016
Add support for flushing headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change, as seen by the test change, but it is very unlikely to break things. Previous discussion was at #668. Any more ideas for tests?