Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the tempfile dependency #51

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Avoid the tempfile dependency #51

merged 3 commits into from
Aug 20, 2021

Conversation

jonas-schievink
Copy link
Contributor

tempfile pulls in an amazing number of dependencies, which we don't really need just for storing a single linker script.

Note that I wasn't able to properly test this because the flip-link testsuite doesn't seem to work.

@jonas-schievink jonas-schievink mentioned this pull request Aug 19, 2021
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I will check the testsuite and see if I can get it to work.

Cargo.toml Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@Urhengulas
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Aug 20, 2021
@bors
Copy link
Contributor

bors bot commented Aug 20, 2021

try

Build succeeded:

@Urhengulas
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 20, 2021

Build succeeded:

@bors bors bot merged commit 40e3a64 into knurling-rs:main Aug 20, 2021
@jonas-schievink jonas-schievink deleted the avoid-tempfile branch August 20, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants