Add expression parser #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it tolerate missing whitespace.
jonathanpallant
force-pushed
the
add-expr-parser
branch
from
220db1f to
20ae9c6
Compare
|
Force pushed to remove redundant function now we're using evalexpr to handle, K, M and G. The trick, it turns out, was just to replace K with *1024 (etc). |
This was referenced Jan 7, 2025
Urhengulas
requested changes
Jan 7, 2025
Co-authored-by: Johann Hemmann <johann.hemmann@ferrous-systems.com>
Minor tidy-ups and typos Co-authored-by: Johann Hemmann <johann.hemmann@ferrous-systems.com>
jonathanpallant
force-pushed
the
add-expr-parser
branch
from
a269977 to
7a18151
Compare
|
Good to go @Urhengulas ? |
Urhengulas
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we use
evalexprto fully evaluate expressions for ORIGIN and LENGTH. This means that we handle subtraction and addition and brackets and whatever else someone might do.Apparently subtraction is quite common when reserving some space for the nRF52 SoftRadio, like:
Fixes #66, #101 and #103