-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cargo-generate with kickstart #38
base: main
Are you sure you want to change the base?
Conversation
I think this would make it a bit easier to start. I think removing setup step 3 and 5 is fine, but the rest of the steps contain information that is still valuable. I would just change the order, because the user has to lookup chip name and HAL name and version before starting kickstart. |
Hello and thank you for the feedback!
Yes, I've updated the README with a very similar command to use with $ kickstart https://github.com/knurling-rs/app-template
Yeah, it makes sense to first introduce the |
Thanks for the PR, @eupn. The UI looks good. Something I found very surprising is that I noticed that I would prefer to keep the 'how to do this manually' info in the README as some people may prefer to download a zip version of this repository rather than clone it. We can divide the README in two sections: (Just thinking out loud: the other thing I noticed is that if you answer 'no' to 'do you want to use an embedded-hal?' then the generated project will fail to build with " |
You can specify the output directory via
Sure, I'll document this as well. I would prefer to keep the 'how to do this manually' info in the README as some people may prefer to download a zip version of this repository rather than clone it. We can divide the README in two sections: Yes, let's keep the manual steps and make two sections in README.
Not sure what would be the preferred approach here if the user doesn't want to use HAL crate. Probably we'll just let the user write the memory.x file themselves by consulting their HAL's docs. |
"thumbv6m-none-eabi (Cortex-M0 and Cortex-M0+)", | ||
"thumbv7m-none-eabi (Cortex-M3)", | ||
"thumbv7em-none-eabi (Cortex-M4 and Cortex-M7 | no FPU)", | ||
"thumbv7em-none-eabihf (Cortex-M4F and Cortex-M7F | with FPU)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We support thumbv8 too
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Hi @eupn, Can you please rebase your PR and resolve the merge conflicts? |
@Urhengulas sure! |
Closes #36.
An example of prompts with defaults:
Tested by compiling the generated project with defaults.