Take endian-ness of the BerkleyDB into account #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcrochet
force-pushed
the
byteorder
branch
2 times, most recently
from
e86b1ff
to
765116e
Compare
|
Thanks for your contribution! Looks like the test is broken. Could you fix it? |
When reading a BDB from a different architecture (for instance, from s390x), it can have a different byte ordering. In order to read an RPM db from any architecture on any architecture, we can inspect the magic number, and if it's in a particular order, we can detect whether to use BigEndian instead of LittleEndian. Signed-off-by: Brad P. Crochet <brad@redhat.com>
Done. |
knqyf263
approved these changes
Jun 27, 2022
|
Thanks for the great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#22
Description of changes:
When reading a BDB from a different architecture (for instance, from
s390x), it can have a different byte ordering. In order to read an
RPM db from any architecture on any architecture, we can inspect the
magic number, and if it's in a particular order, we can detect whether
to use BigEndian instead of LittleEndian.
Signed-off-by: Brad P. Crochet brad@redhat.com
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.