feat: ignore previous benchmark if exit in error (#16) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcu
reviewed
Feb 10, 2020
main.go
Outdated
| if err != nil { | ||
| return nil, xerrors.Errorf("failed to parse a result of benchmarks: %w", err) | ||
| } | ||
| return s, nil | ||
| } | ||
|
|
||
| func runPreviousBenchmark(cmdStr string, args []string) (parse.Set, error) { | ||
| prevSet, err := runBenchmark(cmdStr, args) | ||
| if err != nil && strings.Contains(err.Error(), "exit status 1") { |
There was a problem hiding this comment.
we should probably match any exit status because blocking a pipeline because of any error on previous code is not good
There was a problem hiding this comment.
I think golang always return exit status 1 for any error during the execution of the test.
There was a problem hiding this comment.
not sure... someone could call os.Exit in their tests, for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #16
Description of changes:
If benchmark in base commit fails, cob exit with error. This PR ignore errors in previous benchmark instead of exit with error.
What did change?:
Create a method to run previous benchmark, if benchmark fail, check for
exit status 1message.For benchmark that use a logger, parse.ParseSet could fail due to malformed benchmark line that's why a new function for the parse is created that behave similar to the one in the library.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.