New access_token Authenticator Section#399
Open
Spomky wants to merge 1 commit into
Open
Conversation
Merged
Member
|
Failed PHP CS Fixer changes unrelated, it was fixed in #400, you can rebase now to make it pass
Also, are you going to test that code yourself? |
annuh
reviewed
Jan 31, 2024
| # app/config/packages/security.yaml | ||
| security: | ||
| # ... | ||
| + enable_authenticator_manager: true |
There was a problem hiding this comment.
This line triggers the following error in Symfony 7.0
Unrecognized option "enable_authenticator_manager" under "security". Available options are "access_control", "access_decision_manager", "access_denied_url", "erase_credentials", "firewalls", "hide_user_not_found", "password_hashers", "providers", "role_hierarchy", "session_fixation_strategy".
Member
There was a problem hiding this comment.
Thank you for testing this! That enable_authenticator_manager is not needed for Symfony 7, it was opt-in feature in previous versions but default in Sf 7, you can ignore it.
Probably makes sense to add a comment that this needed only for legacy Symfony <7 projects.
Other than that looks good in this new example to you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to use the new
access_tokenauthenticator for Symfony 6.2+.Related to the discussion in symfony/symfony#49830
Note: yet, the code has not been tested