Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing properties #174

Merged
merged 2 commits into from
Jun 18, 2024
Merged

add missing properties #174

merged 2 commits into from
Jun 18, 2024

Conversation

@vio
Copy link
Member

vio commented Jun 17, 2024

Thank you for the PR @Mouvedia!

all.json is generated from the existing json files. We commit it to easily see what changed compared to the existing props. If you get the chance, can you please:

  1. rebase to get the latest master changes - includes chrome 126 properties ef32ddb
  2. run npm run generate to build the latest all.json
  3. update README.md with the safari versions - it would have been great to have all the properties, but this is quite challenging for old versions

@Mouvedia
Copy link
Contributor Author

Mouvedia commented Jun 17, 2024

all.json is generated from the existing json files
[…]
run npm run generate to build the latest all.json

I need to create a new file for the properties not present in neither safari-2.0.json nor safari-1.1.json.
What would you like it to be named?

@vio
Copy link
Member

vio commented Jun 17, 2024

@Mouvedia what is the source of these properties?

we are currently merging properties extracted automatically from browsers and w3c

@Mouvedia
Copy link
Contributor Author

Mouvedia commented Jun 17, 2024

I have already put the references in OP.

@Mouvedia
Copy link
Contributor Author

  1. rebase
  2. npm run generate
  3. update README.md

Copy link
Member

@vio vio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vio vio merged commit 8d3132c into known-css:master Jun 18, 2024
@vio
Copy link
Member

vio commented Jun 18, 2024

available on v0.34.0

@Mouvedia Thanks again for the PR! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants