Skip to content

Bugfix/etd 235 connectors coinbase #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Bugfix/etd 235 connectors coinbase #4403

wants to merge 2 commits into from
+5 −1

Conversation

martinkyov
Copy link
Contributor

  • Bug fix - Null point exception in case of cancelled transactions

earce
earce reviewed Feb 23, 2022
View reviewed changes
xchange-coinbase/src/main/java/org/knowm/xchange/coinbase/CoinbaseAdapters.java
@@ -57,6 +57,10 @@ public static UserTrades adaptTrades(List<CoinbaseBuySell> transactions, OrderTy
}

private static UserTrade adaptTrade(CoinbaseBuySell transaction, OrderType orderType) {
// Bug fix - Null point exception in case of cancelled transactions
String transactionId = transaction.getTransaction() == null ?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the second null check, if it's null you should just return it

@walec51
Copy link
Collaborator

walec51 commented Jul 30, 2023

@martinkyov could you simplify this according to @earce advice?

@martinkyov
Copy link
Contributor Author

martinkyov commented Aug 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earce earce earce left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinkyov @walec51 @earce