-
Notifications
You must be signed in to change notification settings - Fork 14
Added test coverage... #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…re factory to compareByLastFirst to support test environment
Rock on @ztbrown015! This looks great! Just one minor quibble: rename test/app/contacts/cleanContacts-test.js to test/app/contacts/cleanContact-test.js (remove "s" on end of cleanContact to match original file). Pinging @briancavalier and @habuma to see if they have any objections to merging this. -- John |
Very cool, @ztbrown015, thanks! Looks good to me, aside from @unscriptable's comment. I'll let @habuma have a look as well, and hopefully we can get this merged soon. |
Thanks for the reviewing this! I saw @habuma present on cujo in Columbus this weekend and am really excited to use it in a future project. |
@ztbrown015 great! If you have questions, or want to chat realtime about cujoJS, feel free to join us in #cujojs on freenode IRC. |
I can't imagine @habuma will object :) I added some very minor comments. Once we work through those, I'll go ahead and merge this! |
Also, I have a change that will remove the controller's hard dependency on |
…ode that was erroneously checked in at some point.
Looks great. Thanks for the update. |
for everything except for the application controller. I think the application controller needs to be decoupled from the 'cola/dom/form' injection to be tested in isolation.