Skip to content

Added test coverage... #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2013
Merged

Added test coverage... #1

merged 5 commits into from
Jun 13, 2013

Conversation

ztbrown
Copy link
Contributor

@ztbrown ztbrown commented Jun 9, 2013

for everything except for the application controller. I think the application controller needs to be decoupled from the 'cola/dom/form' injection to be tested in isolation.

@unscriptable
Copy link
Member

Rock on @ztbrown015! This looks great!

Just one minor quibble: rename test/app/contacts/cleanContacts-test.js to test/app/contacts/cleanContact-test.js (remove "s" on end of cleanContact to match original file).

Pinging @briancavalier and @habuma to see if they have any objections to merging this.

-- John

@briancavalier
Copy link
Member

Very cool, @ztbrown015, thanks!

Looks good to me, aside from @unscriptable's comment. I'll let @habuma have a look as well, and hopefully we can get this merged soon.

@ztbrown
Copy link
Contributor Author

ztbrown commented Jun 10, 2013

Thanks for the reviewing this! I saw @habuma present on cujo in Columbus this weekend and am really excited to use it in a future project.

@briancavalier
Copy link
Member

@ztbrown015 great! If you have questions, or want to chat realtime about cujoJS, feel free to join us in #cujojs on freenode IRC.

@briancavalier
Copy link
Member

I can't imagine @habuma will object :) I added some very minor comments. Once we work through those, I'll go ahead and merge this!

@briancavalier
Copy link
Member

Also, I have a change that will remove the controller's hard dependency on cola/dom/form as @ztbrown015 rightly suggested. It'll def help with the controller unit testing situation. After we get this merged, I'll rebase and pull request my change.

…ode that was erroneously checked in at some point.
@briancavalier
Copy link
Member

Looks great. Thanks for the update.

briancavalier added a commit that referenced this pull request Jun 13, 2013
@briancavalier briancavalier merged commit f7aad38 into know-cujojs:master Jun 13, 2013
@ztbrown ztbrown deleted the adding-tests branch June 18, 2013 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants